Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENJPA-2747] Upgrade to JPA 2.2 and use javax.persistence-api spec #17

Closed
wants to merge 1 commit into from

Conversation

@jbonofre
Copy link
Member

jbonofre commented Aug 17, 2018

No description provided.

Copy link
Contributor

rmannibucau left a comment

Small exclusion probably to keep but overall look good. I just wonder a few points:

  1. does the license need some notice work? (EPL/EDL AFAIK)
  2. Should we implement getResultStream (even just doing getResultList().stream() short term) to not break?
  3. We should probably support repeatable annotations (this is a new reflection API but quite fast I think). In other changes there are the datetime support, cdi attributeconverter and java 9 SPI support but I see these ones as less important since it doesnt break anything but thought it is the good opportunity to mention them ;)
@@ -95,11 +95,6 @@
<version>4.0.2.GA</version>
<scope>test</scope>
<exclusions>
<!-- force usage of the geronimo-jpa_2.1_spec -->

This comment has been minimized.

Copy link
@rmannibucau

rmannibucau Aug 17, 2018

Contributor

we should pby keep that excluded, no?

@ilgrosso

This comment has been minimized.

Copy link
Member

ilgrosso commented Mar 5, 2019

We have moved to geronimo's JPA specs 2.2 in 44aede2, closing this PR.
Thanks anyway @jbonofre !

@ilgrosso ilgrosso closed this Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.