Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENJPA-2567] various MySql text types support is added #18

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
3 participants
@solomax
Copy link
Contributor

commented Aug 27, 2018

No description provided.

@ilgrosso

This comment has been minimized.

Copy link
Member

commented Sep 2, 2018

Thanks @solomax this PR lgtm and I would merge it both to trunk and 2_4_X: @struberg @rmannibucau any objection?

@rmannibucau

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2018

+1

@ilgrosso

This comment has been minimized.

Copy link
Member

commented Sep 3, 2018

@solomax would you mind applying the same fixes to MariaDBDictionary?

@solomax

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2018

Sure,
will do later tonight

@solomax

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2018

@ilgrosso MariaDb changes were added, previous PR had some files in wrong places (was done by git apply svn.patch), sorry for this

@asfgit asfgit closed this in 9a98d6a Sep 3, 2018

@ilgrosso

This comment has been minimized.

Copy link
Member

commented Sep 3, 2018

@solomax No troubles as we're on SVN, hence I could only grab the full diff for this PR and manually apply it to both trunk and 2.4.x (with small modifications to restore Java 6 compatibility) branches.
Thanks!

@solomax

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2018

At Apache OpenMeetings we have switched to GitBox
It is easier to review/comment and merge via PRs :)

@ilgrosso

This comment has been minimized.

Copy link
Member

commented Sep 3, 2018

We're also using GitBox at CXF, while at Syncope we're on the old Git / GitHub sync, still not finding enough reasons to move to the former, actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.