Skip to content

OPENNLP-1829: Transfer DirectoryModelFinder to OpenNLP core#1045

Merged
mawiesne merged 1 commit into
mainfrom
OPENNLP-1829-Transfer-DirectoryModelFinder-to-core
May 15, 2026
Merged

OPENNLP-1829: Transfer DirectoryModelFinder to OpenNLP core#1045
mawiesne merged 1 commit into
mainfrom
OPENNLP-1829-Transfer-DirectoryModelFinder-to-core

Conversation

@mawiesne
Copy link
Copy Markdown
Contributor

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne requested a review from rzo1 May 12, 2026 08:03
@mawiesne mawiesne self-assigned this May 12, 2026
@mawiesne mawiesne added the java Pull requests that update Java code label May 12, 2026
@rzo1 rzo1 requested a review from krickert May 12, 2026 08:04
@rzo1
Copy link
Copy Markdown
Contributor

rzo1 commented May 12, 2026

@mawiesne "Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.6.0:check (validate) on project opennlp-model-resolver: You have 4 Checkstyle violations. -> [Help 1]"

@mawiesne mawiesne force-pushed the OPENNLP-1829-Transfer-DirectoryModelFinder-to-core branch from bd45c1d to 27ad2c7 Compare May 12, 2026 08:10
@mawiesne mawiesne merged commit 054c884 into main May 15, 2026
9 checks passed
@mawiesne mawiesne deleted the OPENNLP-1829-Transfer-DirectoryModelFinder-to-core branch May 18, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants