OPENNLP-229: Write a test case for the NameFinderSequenceValidator class #125
Conversation
| private static NameFinderSequenceValidator validator = new NameFinderSequenceValidator(); | ||
| private static String START_A = "TypeA-" + NameFinderME.START; | ||
| private static String CONTINUE_A = "TypeA-" + NameFinderME.CONTINUE; | ||
| private static String OTHER_A = "TypeA-" + NameFinderME.OTHER; |
There was a problem hiding this comment.
I don't know if it make sense to concat "TypeA-" + NameFinderME.OTHER, we usually have only NameFinderME.OTHER
There was a problem hiding this comment.
I need more that one name type for the test and therefore I can not just use NameFinderME.START/OTHER/CONT. Running on some test data showed me that the Name Type is added in front of the "outcome" (or "default-" is added.)
There was a problem hiding this comment.
What he means is that there is no OTHER_A or OTHER_B it is always just OTHER. Indicating that none of the types in the model cover that particular token.
|
|
||
| } | ||
|
|
||
| @Ignore |
There was a problem hiding this comment.
That is a good solution here. We can merge this PR and then the other PR with the bug fix can enable the test case.
|
Commit message in imperative and it should contain the jira: And a easy way to update an existing PR is:
|
thygesen
force-pushed
the
opennlp-229
branch
2 times, most recently
from
2f5673b
to
93bdf5d
Compare
OPENNLP-229: Add test for NameFinderSequenceValidator OPENNLP-229: Add test for NameFinderSequenceValidator
thygesen
force-pushed
the
opennlp-229
branch
from
93bdf5d
to
4c89b30
Compare
|
+1 lgtm |
|
Thanks for contributing this. I merged this now and edited your commit message a bit (it contained multiple identical lines) |
I have written the missing test for NameFinderSequenceValidator. Please note that the test:testContinueAfterStartAndNotSameType has temporary been disabled because it will fail due to a minor "bug" in the NameFinderSequenceValidator. At the moment the validator accepts Continue after Start even though they are different name types.