From 282f8d109ac96de26ebb7a8134abba51ec934bca Mon Sep 17 00:00:00 2001
From: smarthi <smarthi@apache.org>
Date: Mon, 23 Jan 2017 21:47:54 -0500
Subject: [PATCH] OPENNLP-951: Add a central RAT-exclude file

---
 README.md                        |  2 +-
 opennlp-morfologik-addon/pom.xml | 21 ------------
 opennlp-tools/pom.xml            | 58 ++------------------------------
 pom.xml                          |  8 +++--
 rat-excludes                     | 57 +++++++++++++++++++++++++++++++
 5 files changed, 66 insertions(+), 80 deletions(-)
 create mode 100644 rat-excludes

diff --git a/README.md b/README.md
index b1e1e1ac7..faff141d5 100644
--- a/README.md
+++ b/README.md
@@ -24,7 +24,7 @@ Welcome to Apache OpenNLP!
 [![GitHub license](https://img.shields.io/badge/license-Apache%202-blue.svg)](https://raw.githubusercontent.com/apache/opennlp/master/LICENSE)
 [![GitHub forks](https://img.shields.io/github/forks/apache/opennlp.svg)](https://github.com/apache/opennlp/network)
 [![GitHub stars](https://img.shields.io/github/stars/apache/opennlp.svg)](https://github.com/apache/opennlp/stargazers)
-[![Twitter Follow](https://img.shields.io/twitter/follow/opennlp.svg?style=social&label=Follow)](https://twitter.com/ApacheOpenNLP)
+[![Twitter Follow](https://img.shields.io/twitter/follow/ApacheOpennlp.svg?style=social)](https://twitter.com/ApacheOpenNLP)
 
 The Apache OpenNLP library is a machine learning based toolkit for the processing of natural language text.
 It supports the most common NLP tasks, such as tokenization, sentence segmentation,
diff --git a/opennlp-morfologik-addon/pom.xml b/opennlp-morfologik-addon/pom.xml
index b10498b6d..d62a70a57 100644
--- a/opennlp-morfologik-addon/pom.xml
+++ b/opennlp-morfologik-addon/pom.xml
@@ -62,27 +62,6 @@
 			<artifactId>junit</artifactId>
 			<scope>test</scope>
 		</dependency>
-
 	</dependencies>
 
-	<build>
-		<plugins>
-			<plugin>
-		        <groupId>org.apache.rat</groupId>
-		        <artifactId>apache-rat-plugin</artifactId>
-		        <executions>
-		          <execution>
-		            <id>default-cli</id>
-		            <configuration>
-		              <excludes>
-		                <!-- test data -->
-		                <exclude>src/test/resources/*.txt</exclude>
-		  				<exclude>src/test/resources/*.info</exclude>
-		              </excludes>
-		            </configuration>
-		          </execution>
-		        </executions>
-	      	</plugin>
-		</plugins>
-	</build>
 </project>
diff --git a/opennlp-tools/pom.xml b/opennlp-tools/pom.xml
index af54f431d..9441ebbfd 100644
--- a/opennlp-tools/pom.xml
+++ b/opennlp-tools/pom.xml
@@ -100,12 +100,12 @@
             
       <plugin>
         <artifactId>maven-javadoc-plugin</artifactId>
+        <configuration>
+          <excludePackageNames>opennlp.tools.cmdline</excludePackageNames>
+        </configuration>
         <executions>
           <execution>
             <id>create-javadoc-jar</id>
-            <configuration>
-              <excludePackageNames>opennlp.tools.cmdline</excludePackageNames>
-            </configuration>
           </execution>
         </executions>
       </plugin>
@@ -126,58 +126,6 @@
           </instructions>
         </configuration>
       </plugin>
-			
-      <plugin>
-        <groupId>org.apache.rat</groupId>
-        <artifactId>apache-rat-plugin</artifactId>
-        <executions>
-          <execution>
-            <id>default-cli</id>
-            <configuration>
-              <excludes>
-                <!-- test data -->
-                <exclude>src/test/resources/opennlp/tools/chunker/*.txt</exclude>
-                <exclude>src/test/resources/opennlp/tools/formats/*.sample</exclude>
-                <exclude>src/test/resources/opennlp/tools/namefind/*.txt</exclude>
-                <exclude>src/test/resources/opennlp/tools/namefind/*.train</exclude>
-                <exclude>src/test/resources/opennlp/tools/parser/en_head_rules</exclude>
-                <exclude>src/test/resources/opennlp/tools/parser/en_head_rules</exclude>
-                <exclude>src/test/resources/opennlp/tools/parser/parser.train</exclude>
-                <exclude>src/test/resources/opennlp/tools/parser/test.parse</exclude>
-                <exclude>src/test/resources/opennlp/tools/postag/AnnotatedSentences.txt</exclude>
-                <exclude>src/test/resources/opennlp/tools/sentdetect/Sentences.txt</exclude>
-                <exclude>src/test/resources/opennlp/tools/tokenize/token.train</exclude>
-                <exclude>src/main/java/opennlp/tools/ml/maxent/AllEnglishAffixes.txt</exclude>
-                <exclude>src/test/resources/data/opennlp/maxent/io/rvfes-bug-data-broken.txt</exclude>
-                <exclude>src/test/resources/data/opennlp/maxent/io/rvfes-bug-data-ok.txt</exclude>
-                <exclude>src/test/resources/data/opennlp/maxent/real-valued-weights-training-data.txt</exclude>
-                <exclude>src/test/resources/data/opennlp/maxent/repeat-weighting-training-data.txt</exclude>
-                <exclude>src/test/resources/data/ppa/bitstrings</exclude>
-                <exclude>src/test/resources/data/ppa/devset</exclude>
-                <exclude>src/test/resources/data/ppa/test</exclude>
-                <exclude>src/test/resources/data/ppa/training</exclude>
-                <exclude>src/test/resources/data/ppa/NOTICE</exclude>
-                <exclude>src/test/resources/opennlp/tools/doccat/DoccatSample.txt</exclude>
-                <exclude>src/test/resources/opennlp/tools/formats/brat/voa-with-entities.ann</exclude>
-                <exclude>src/test/resources/opennlp/tools/formats/brat/voa-with-entities.txt</exclude>
-                <exclude>src/test/resources/opennlp/tools/formats/brat/voa-with-relations.ann</exclude>
-                <exclude>src/test/resources/opennlp/tools/formats/brat/voa-with-relations.txt</exclude>
-                
-		<exclude>src/test/resources/opennlp/tools/languagemodel/sentences.txt</exclude>
-		<exclude>src/test/resources/opennlp/tools/lemmatizer/trial.old.tsv</exclude>
-		<exclude>src/test/resources/opennlp/tools/lemmatizer/output.txt</exclude>
-
-                <!-- head rule files, format does not allow AL header -->
-                <exclude>lang/en/parser/en-head_rules</exclude>
-                <exclude>lang/es/parser/es-head-rules</exclude>
-
-                <!-- other licence -->
-		            <exclude>src/main/java/opennlp/tools/stemmer/snowball/*.java</exclude>
-              </excludes>
-            </configuration>
-          </execution>
-        </executions>
-      </plugin>
     </plugins>
   </build>
 </project>
diff --git a/pom.xml b/pom.xml
index 24fb765b3..5ea3ae166 100644
--- a/pom.xml
+++ b/pom.xml
@@ -352,12 +352,14 @@
 				<plugin>
 					<groupId>org.apache.rat</groupId>
 					<artifactId>apache-rat-plugin</artifactId>
+					<configuration>
+						<excludes>
+							<excludesFile>rat-excludes</excludesFile>
+						</excludes>
+					</configuration>
 					<executions>
 						<execution>
 							<id>default-cli</id>
-							<configuration>
-								<numUnapprovedLicenses>0</numUnapprovedLicenses>
-							</configuration>
 						</execution>
 					</executions>
 				</plugin>
diff --git a/rat-excludes b/rat-excludes
new file mode 100644
index 000000000..33a787b59
--- /dev/null
+++ b/rat-excludes
@@ -0,0 +1,57 @@
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+-->
+
+src/test/resources/opennlp/tools/*/*.txt
+src/test/resources/opennlp/tools/*/*.sample
+src/test/resources/opennlp/tools/*/*.txt
+src/test/resources/opennlp/tools/*/*.train
+src/test/resources/opennlp/tools/parser/en_head_rules
+src/test/resources/opennlp/tools/parser/en_head_rules
+src/test/resources/opennlp/tools/parser/parser.train
+src/test/resources/opennlp/tools/parser/test.parse
+src/test/resources/opennlp/tools/postag/AnnotatedSentences.txt
+src/test/resources/opennlp/tools/sentdetect/Sentences.txt
+src/test/resources/opennlp/tools/tokenize/token.train
+src/main/java/opennlp/tools/ml/maxent/AllEnglishAffixes.txt
+src/test/resources/data/opennlp/maxent/io/rvfes-bug-data-broken.txt
+src/test/resources/data/opennlp/maxent/io/rvfes-bug-data-ok.txt
+src/test/resources/data/opennlp/maxent/real-valued-weights-training-data.txt
+src/test/resources/data/opennlp/maxent/repeat-weighting-training-data.txt
+src/test/resources/data/ppa/bitstrings
+src/test/resources/data/ppa/devset
+src/test/resources/data/ppa/test
+src/test/resources/data/ppa/training
+src/test/resources/data/ppa/NOTICE
+src/test/resources/opennlp/tools/doccat/DoccatSample.txt
+src/test/resources/opennlp/tools/formats/brat/voa-with-entities.ann
+src/test/resources/opennlp/tools/formats/brat/voa-with-entities.txt
+src/test/resources/opennlp/tools/formats/brat/voa-with-relations.ann
+src/test/resources/opennlp/tools/formats/brat/voa-with-relations.txt
+src/test/resources/opennlp/tools/languagemodel/sentences.txt
+src/test/resources/opennlp/tools/lemmatizer/trial.old.tsv
+src/test/resources/opennlp/tools/lemmatizer/output.txt
+
+<!-- head rule files, format does not allow AL header -->
+lang/en/parser/en-head_rules
+lang/es/parser/es-head-rules
+src/test/resources/*.txt
+src/test/resources/*.info
+
+<!-- other licence -->
+src/main/java/opennlp/tools/stemmer/snowball/*.java