Skip to content

[2.x] OPENNLP-1788: Enhance opennlp.tools.util.Version to parse suffixed version #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzo1 merged 1 commit into from
Nov 29, 2025
Merged

[2.x] OPENNLP-1788: Enhance opennlp.tools.util.Version to parse suffixed version #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion opennlp-tools/src/main/java/opennlp/tools/util/Version.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,14 @@ public static Version parse(String version) {
throw new NumberFormatException("Invalid version format '" + version + "', expected two dots!");
}

int indexThirdDot = version.indexOf('.', indexSecondDot + 1);
int indexFirstDash = version.indexOf('-');

int versionEnd;
if (indexFirstDash == -1) {
if (indexFirstDash == -1 && indexThirdDot == -1) {
versionEnd = version.length();
} else if (indexThirdDot != -1) {
versionEnd = indexThirdDot;
} else {
versionEnd = indexFirstDash;
}
Expand Down
8 changes: 8 additions & 0 deletions opennlp-tools/src/test/java/opennlp/tools/util/VersionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@ void testParseSnapshot() {
Version.parse("1.5.2-SNAPSHOT"));
}

@Test
void testParseSuffixedVersion() {
Assertions.assertEquals(new Version(1, 5, 4, false),
Version.parse("1.5.4.foobar-007"));
Assertions.assertEquals(new Version(1, 5, 4, false),
Version.parse("1.5.4.foobar"));
}

@Test
void testParseProjectVersionWithRarePatchVersion() {
// A rare extra patch version is present (e.g., 2.5.6.1), which OpenNLP normally doesn't use.
Expand Down