Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove namespace property from wskprops #434

Merged
merged 3 commits into from May 7, 2019

Conversation

@rabbah
Copy link
Member

commented Apr 25, 2019

The setting of a namespace in wskprops can lead to surprising failures when it does not match the auth key. This value used to be there when namespaces and keys were not 1-1 but that hasn't been the case for a long time.

This patch remove --namespace from property set/unset but preserves --namespace in property get.

Partially fixes #137. Will open a subsequent PR to re-purpose wsk namespace get.

rabbah added some commits Apr 25, 2019

@rabbah rabbah force-pushed the rabbah:nsprop branch from 7ea1f5b to 59c11b8 Apr 25, 2019

@rabbah rabbah requested review from dubee and sciabarracom Apr 25, 2019

@rabbah rabbah force-pushed the rabbah:nsprop branch from 59c11b8 to 657f6dc Apr 25, 2019

@rabbah rabbah force-pushed the rabbah:nsprop branch from 657f6dc to 4b70b07 Apr 25, 2019

@neerajmangal

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

sorry @rabbah, for the late response. I tested the changes and all looks good.

@sciabarracom

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

I built the cli and I tried with an existing configuration with a namespace:

Old:
wsk -i action list
error: Unable to obtain the list of actions for namespace 'neuronix_cloud': The supplied authentication is not authorized to access 'neuronix_cloud'. (code nVQD2dAZZbjgN4Z1fqsXkE7Q8aAFVFSi)
Run 'wsk --help' for usage.

New:
./wsk -i action list
actions

@sciabarracom
Copy link
Contributor

left a comment

works for me

@rabbah rabbah merged commit 2d2d673 into apache:master May 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rabbah

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.