Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid module name in intellijRunConfig script #4760

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@upgle
Copy link
Contributor

upgle commented Dec 3, 2019

Description

Because the module name is incorrect, the IntelliJ utility script doesn't make valid run configurations.
So it fixes the invalid module name.

My changes affect the following components

  • General tooling

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #4760 into master will decrease coverage by 5.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4760      +/-   ##
==========================================
- Coverage   83.59%   78.31%   -5.28%     
==========================================
  Files         198      198              
  Lines        8837     8837              
  Branches      606      606              
==========================================
- Hits         7387     6921     -466     
- Misses       1450     1916     +466
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0% <0%> (-100%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0% <0%> (-100%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0% <0%> (-100%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0% <0%> (-100%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0% <0%> (-96.23%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0% <0%> (-93.85%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0% <0%> (-92.31%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0% <0%> (-77.78%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0% <0%> (-74.08%) ⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala 7.69% <0%> (-50%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6778b...c905f7e. Read the comment docs.

@chetanmeh chetanmeh merged commit 0c9d0ac into apache:master Dec 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@upgle upgle deleted the upgle:fix-tool-intellij branch Dec 3, 2019
@upgle

This comment has been minimized.

Copy link
Contributor Author

upgle commented Dec 3, 2019

@chetanmeh thank you for the quick merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.