Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a change log. #5014

Merged
merged 7 commits into from Oct 27, 2020
Merged

Add a change log. #5014

merged 7 commits into from Oct 27, 2020

Conversation

style95
Copy link
Member

@style95 style95 commented Oct 26, 2020

This is to add the CHANGELOG.md.

I think we need to merge this PR into the master branch to add the initial version of CHANGELOG.md that includes the content for 0.9.0-incubating.
And Add one more commit to the 1.0.0 branch to update the CHANGELOG.md to includes the changes since 0.9.0-incubating.


## Apache 1.0.0
### Branch: [1.0.0](https://github.com/apache/openwhisk/tree/1.0.0)
### Notable changes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed all commits since 0.9.0 and arbitrarily chose notable changes.
Please let me know if anything is missing or should be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. That was quite a large list of changes to go through over the last couple years

@style95 style95 changed the title [WIP] Add a change log. Add a change log. Oct 26, 2020
@style95
Copy link
Member Author

style95 commented Oct 26, 2020

I think CHANGELOG.md should be in both master and 1.0.0 branch.
So I included all notable changes since 0.9.0.

### Branch: [1.0.0](https://github.com/apache/openwhisk/tree/1.0.0)
### Notable changes
- Improvements to parameter encryption to support per-namespace keys. ([#4855](https://github.com/apache/openwhisk/pull/4855), [@rabbah](https://github.com/rabbah))
- Use latest code if action's revision is mismatched. ([#4954](https://github.com/apache/openwhisk/pull/4954), [@upgle](https://github.com/upgle))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed a similar format with the changelog of the K8S project.
Hoping this could give another credit to contributors.

@rabbah
Copy link
Member

rabbah commented Oct 26, 2020

🎉 awesome list of contributors.

Copy link
Member

@rabbah rabbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, we're not consistent in how we refer to runtimes. I left them alone because I couldn't decide if we should use Lang version or kind:version.

CHANGELOG.md Outdated
- Update docker client version to 18.06.3. ([#4430](https://github.com/apache/openwhisk/pull/4430), [@style95](https://github.com/style95))
- Add `binding` annotation to record an action path not resolved. ([#4211](https://github.com/apache/openwhisk/pull/4211), [@upgle](https://github.com/upgle))
- Add SPI for invoker. ([#4453](https://github.com/apache/openwhisk/pull/4453), [@style95](https://github.com/style95))
- Enable couchdb persist_path in a distributed environment as well. ([#4290](https://github.com/apache/openwhisk/pull/4290), [@style95](https://github.com/style95))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Enable couchdb persist_path in a distributed environment as well. ([#4290](https://github.com/apache/openwhisk/pull/4290), [@style95](https://github.com/style95))
- Enable CouchDB `persist_path` in a distributed environment. ([#4290](https://github.com/apache/openwhisk/pull/4290), [@style95](https://github.com/style95))

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #5014 into master will decrease coverage by 6.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5014      +/-   ##
==========================================
- Coverage   83.75%   76.91%   -6.84%     
==========================================
  Files         202      202              
  Lines        9786     9786              
  Branches      409      409              
==========================================
- Hits         8196     7527     -669     
- Misses       1590     2259     +669     
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.85%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0.00% <0.00%> (-78.58%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0.00% <0.00%> (-74.08%) ⬇️
...ore/database/azblob/AzureBlobAttachmentStore.scala 11.53% <0.00%> (-60.58%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ba987...3f057f3. Read the comment docs.

style95 and others added 2 commits October 27, 2020 13:24
Co-authored-by: rodric rabbah <rodric@gmail.com>
- Add NodeJS 14 runtime. ([#4902](https://github.com/apache/openwhisk/pull/4902), [@rabbah](https://github.com/rabbah))
- Create AES128 and AES256 encryption for parameters. ([#4756](https://github.com/apache/openwhisk/pull/4756), [@mcdan](https://github.com/mcdan))
- Implement an ElasticSearchActivationStore. ([#4724](https://github.com/apache/openwhisk/pull/4724), [@jiangpengcheng](https://github.com/jiangpengcheng))
- Add Swift 5.1 runtime to runtimes.json. ([#4803](https://github.com/apache/openwhisk/pull/4803), [@dgrove-oss](https://github.com/dgrove-oss))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into our runtime repositories and chose the following format to specify runtimes.

{Lang} {Version} {runtime/kind}

So I updated the mentioned runtimes as follow:

  • NodeJS 14 runtime
  • Swift 5.1 runtime
  • .NET Core 3.1 runtime
  • PHP 7.4 runtime
  • Ruby 2.5 runtime

And they conform to the format in our runtime repositories.

Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the effort on this!

@style95 style95 merged commit ddb2662 into apache:master Oct 27, 2020
@style95
Copy link
Member Author

style95 commented Oct 27, 2020

I merged this to release the OW 1.0.0.
I think it should not be dragging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants