ORC-1189: Update README.md and help command message in benchmark module and .gitignore
#1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwlon
changed the title
mwlon
changed the title
dongjoon-hyun
changed the title
README.md and help command message in benchmark module and .gitignore
dongjoon-hyun
approved these changes
May 26, 2022
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 26, 2022
…` module and `.gitignore` ### What changes were proposed in this pull request? Make docs and gitignore a bit more helpful for benchmark suite ### Why are the changes needed? * Benchmark `generate` command should not refer to itself as `convert`: ```$ java -jar core/target/orc-benchmarks-core-*-uber.jar generate data --help usage: convert <root> -c,--compress <arg> List of compression -d,--data <arg> List of data sets -f,--format <arg> List of formats -h,--help Provide help -s,--sales <arg> Number of records for sales ``` * README command for packaging the benchmark suite currently runs all tests; usually this is not necessary * benchmark generated data should be in .gitignore so that they are not accidentally added to git history ### How was this patch tested? No functionality or tests were modified Closes #1142 from mwlon/ORC-1189-docs. Authored-by: mwlon <m.w.loncaric@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit dc2d864) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 26, 2022
…` module and `.gitignore` ### What changes were proposed in this pull request? Make docs and gitignore a bit more helpful for benchmark suite ### Why are the changes needed? * Benchmark `generate` command should not refer to itself as `convert`: ```$ java -jar core/target/orc-benchmarks-core-*-uber.jar generate data --help usage: convert <root> -c,--compress <arg> List of compression -d,--data <arg> List of data sets -f,--format <arg> List of formats -h,--help Provide help -s,--sales <arg> Number of records for sales ``` * README command for packaging the benchmark suite currently runs all tests; usually this is not necessary * benchmark generated data should be in .gitignore so that they are not accidentally added to git history ### How was this patch tested? No functionality or tests were modified Closes #1142 from mwlon/ORC-1189-docs. Authored-by: mwlon <m.w.loncaric@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit dc2d864) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to main/1.8/1.7. |
|
Thanks for the review, @dongjoon-hyun |
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
…` module and `.gitignore` ### What changes were proposed in this pull request? Make docs and gitignore a bit more helpful for benchmark suite ### Why are the changes needed? * Benchmark `generate` command should not refer to itself as `convert`: ```$ java -jar core/target/orc-benchmarks-core-*-uber.jar generate data --help usage: convert <root> -c,--compress <arg> List of compression -d,--data <arg> List of data sets -f,--format <arg> List of formats -h,--help Provide help -s,--sales <arg> Number of records for sales ``` * README command for packaging the benchmark suite currently runs all tests; usually this is not necessary * benchmark generated data should be in .gitignore so that they are not accidentally added to git history ### How was this patch tested? No functionality or tests were modified Closes apache#1142 from mwlon/ORC-1189-docs. Authored-by: mwlon <m.w.loncaric@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make docs and gitignore a bit more helpful for benchmark suite
Why are the changes needed?
generatecommand should not refer to itself asconvert:How was this patch tested?
No functionality or tests were modified