Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-363 Enable zstd decompression in ORC Java reader #268

Closed
wants to merge 1 commit into from

Conversation

xndai
Copy link
Contributor

@xndai xndai commented May 14, 2018

  1. Upgrade aircompressor lib to 0.11
  2. Enable Zstd decompression in Java reader
  3. Zstd compression is still not availiable. Will throw illegal argument
    exception if writer uses zstd compression.

Change-Id: Ic5492b09af4e1e51215e62ed29233729857c45ac

1. Upgrade aircompressor lib to 0.11
2. Enable Zstd decompression in Java reader
3. Zstd compression is still not availiable. Will throw illegal argument
exception if writer uses zstd compression.

Change-Id: Ic5492b09af4e1e51215e62ed29233729857c45ac
Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@omalley
Copy link
Contributor

omalley commented May 16, 2018

I'd rather hold off on this until we can do an end-to-end test.

@xndai
Copy link
Contributor Author

xndai commented May 17, 2018

The current solution is not perfect. But at least it gives us some ability to read zstd Orc files, which I believe is important from the compatibility perspective - our in-house system has zstd Orc that would like to be consumed by Hive, Spark, etc. I am not sure when the zstd compressor will be available. It's probably another 6 months or a year.

If we enable zstd on C++ reader/writer first. Then we enable Java reader to consume zstd Orc from C++ writer. Would you consider that as end-to-end test?

@xndai
Copy link
Contributor Author

xndai commented Aug 10, 2018

Hi all, I'd like to bring this up again. It's almost another three months, and we haven't seen the zstd java library yet. I would suggest we move forward to add zstd support in C++ reader/writer. And at the same time, enable Java reader by this change.

@t3rmin4t0r
Copy link
Contributor

I'm in favour of using the org.apache.hadoop.io.compress.ZStandardCodec if it is available from Hadoop.

@xndai
Copy link
Contributor Author

xndai commented Nov 6, 2018

Close this PR since @wgtmac is working on this through ORC-363.

@xndai xndai closed this Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants