Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specification of float encoding in BloomFilter #400

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
1 participant
@dain
Copy link
Contributor

commented Jun 7, 2019

Floats are converted to double and added to BloomFilter according to the double rules.

The relevant code in the Java ORC writer is here (note that value is type float, and the code calls addDouble)

float value = (float) vec.vector[0];
indexStatistics.updateDouble(value);
if (createBloomFilter) {
if (bloomFilter != null) {
bloomFilter.addDouble(value);
}
bloomFilterUtf8.addDouble(value);
}
for (int i = 0; i < length; ++i) {
utils.writeFloat(stream, value);
}

Fix specification of float encoding in BloomFilter
Floats are converted to double and added to BloomFilter according to the double rules.

@omalley omalley closed this in 2df3f15 Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.