From 12545de3833034130097bb6a5bab3f194ce560e0 Mon Sep 17 00:00:00 2001 From: Owen O'Malley Date: Tue, 17 Jan 2017 14:04:04 -0800 Subject: [PATCH] ORC-131. Fix getRawDataSize() in WriterImpl. (omalley) --- java/core/src/java/org/apache/orc/impl/WriterImpl.java | 1 + java/tools/src/test/org/apache/orc/tools/TestFileDump.java | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/java/core/src/java/org/apache/orc/impl/WriterImpl.java b/java/core/src/java/org/apache/orc/impl/WriterImpl.java index c364ca0027..d9140e806c 100644 --- a/java/core/src/java/org/apache/orc/impl/WriterImpl.java +++ b/java/core/src/java/org/apache/orc/impl/WriterImpl.java @@ -2748,6 +2748,7 @@ private long writeFooter() throws IOException { OrcProto.Footer.Builder builder = OrcProto.Footer.newBuilder(); builder.setNumberOfRows(rowCount); builder.setRowIndexStride(rowIndexStride); + rawDataSize = computeRawDataSize(); // serialize the types writeTypes(builder, schema); // add the stripe information diff --git a/java/tools/src/test/org/apache/orc/tools/TestFileDump.java b/java/tools/src/test/org/apache/orc/tools/TestFileDump.java index 65ff404ec3..1556ab4805 100644 --- a/java/tools/src/test/org/apache/orc/tools/TestFileDump.java +++ b/java/tools/src/test/org/apache/orc/tools/TestFileDump.java @@ -238,6 +238,8 @@ public void testDump() throws Exception { writer.addRowBatch(batch); } writer.close(); + assertEquals(2079000, writer.getRawDataSize()); + assertEquals(21000, writer.getNumberOfRows()); PrintStream origOut = System.out; String outputFilename = "orc-file-dump.out"; FileOutputStream myOut = new FileOutputStream(workDir + File.separator + outputFilename); @@ -306,6 +308,8 @@ public void testDataDump() throws Exception { writer.addRowBatch(batch); writer.close(); + assertEquals(1564, 0, writer.getRawDataSize()); + assertEquals(2, writer.getNumberOfRows()); PrintStream origOut = System.out; ByteArrayOutputStream myOut = new ByteArrayOutputStream();