-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-4496. Separate client and server2server GRPC services of datanode #1636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @elek for working on this. The PR LGTM overall. A few comments added inline.
...r-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationServer.java
Show resolved
Hide resolved
...r-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationServer.java
Outdated
Show resolved
Hide resolved
...r-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationServer.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, +1 pending CI
...r-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationServer.java
Show resolved
Hide resolved
|
CI is green. Merging it now. Thanks for the review @xiaoyuyao |
What changes were proposed in this pull request?
Today both the closed-container-replication service and datanode client service are exposed on the same datanode port which makes it impossible to use different network configuration (like mutual TLS).
In this patch I propose to separate the two services and use two network ports.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4496
How was this patch tested?
Tested the replication with local docker-compose cluster (adding keys, closing container, waiting for replication)