Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-4496. Separate client and server2server GRPC services of datanode #1636

Merged
merged 15 commits into from
Jan 6, 2021

Conversation

elek
Copy link
Member

@elek elek commented Nov 30, 2020

What changes were proposed in this pull request?

Today both the closed-container-replication service and datanode client service are exposed on the same datanode port which makes it impossible to use different network configuration (like mutual TLS).

In this patch I propose to separate the two services and use two network ports.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4496

How was this patch tested?

Tested the replication with local docker-compose cluster (adding keys, closing container, waiting for replication)

@elek elek requested a review from xiaoyuyao November 30, 2020 15:45
Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elek for working on this. The PR LGTM overall. A few comments added inline.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 pending CI

@elek
Copy link
Member Author

elek commented Jan 6, 2021

CI is green. Merging it now. Thanks for the review @xiaoyuyao

@elek elek merged commit a0a936d into apache:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants