HDDS-4917.[FSO]Implement ACL requests for new layout #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linyiqun
reviewed
Mar 12, 2021
...e-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/acl/OMKeyAddAclRequestV1.java
Outdated
Show resolved
Hide resolved
...anager/src/main/java/org/apache/hadoop/ozone/om/request/key/acl/OMKeyRemoveAclRequestV1.java
Outdated
Show resolved
Hide resolved
linyiqun
approved these changes
Mar 13, 2021
rakeshadr
reviewed
Mar 15, 2021
...zone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/acl/OMKeyAclRequestV1.java
Show resolved
Hide resolved
|
+1 patch looks good to me. Thanks @sadanand48 for the contribution. Thanks a lot @linyiqun for the reviews. |
|
@xiaoyuyao this patch is expecting prefixes and the key should exist in DB. Otw, it will throw Key_Not_Found exception. IIRC, we have discussed this case of non-existent path and not required to handle this case. Could you please add your thoughts. Thanks! IMHO, I am open to discuss this point and if we need to support then it can be handled separately in a new jira. I'm merging this PR now. |
rakeshadr
pushed a commit
that referenced
this pull request
Mar 27, 2021
rakeshadr
pushed a commit
that referenced
this pull request
Apr 7, 2021
rakeshadr
pushed a commit
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement ACL api's like getAcl, addAcl, setAcl ,removeAcl in the new layout V1.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4917
How was this patch tested?
Added Unit test