HDDS-5244. Allow multiple OM request versions to be supported at same layout version. #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @errose28 for review. |
errose28
reviewed
May 21, 2021
There was a problem hiding this comment.
Thanks for working on this @avijayanhwx . Mostly LGTM just minor comments/questions in line.
...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerPrepare.java
Outdated
Show resolved
Hide resolved
...ger/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOmVersionManagerRequestFactory.java
Outdated
Show resolved
Hide resolved
...one/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOMVersionManager.java
Outdated
Show resolved
Hide resolved
rakeshadr
reviewed
May 24, 2021
...one-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java
Show resolved
Hide resolved
...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMLayoutFeatureAspect.java
Show resolved
Hide resolved
|
Thanks for the review @errose28 / @rakeshadr. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
May 27, 2021
* HDDS-3698-nonrolling-upgrade: HDDS-5244. Allow multiple OM request versions to be supported at same layout version. (apache#2265) HDDS-5138. Upgrade related RPC calls should be allowed only for admins. (apache#2217) HDDS-5226. Do not fail SCM HA pre-finalize validation if SCM HA was already being used. (apache#2257) Conflicts: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove use of instance factory in OM request handling switch. Added a new point cut in the OM aspect that makes sure new OM requests can be brought in through a layout version.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5244
How was this patch tested?
Added unit tests.
Manually tested.