HDDS-8357. Exclude spring-jcl to avoid dependency conflict#4544
Merged
Conversation
smengcl
approved these changes
Apr 10, 2023
smengcl
left a comment
smengcl
left a comment
Contributor
There was a problem hiding this comment.
+1 as long as it won't break other Recon functionality. cc @devmadhuu
devmadhuu
reviewed
Apr 11, 2023
Contributor
|
Thanks @okumin for the patch, @devmadhuu, @smengcl for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Exclude
spring-jclso as to suppress the following log.This issue happens because
spring-jclintroduces another implementation of LogFactory and the implementation ofspring-jclcan be loaded.This PR takes the approach to exclude
spring-jclfollowing the instruction.There would be other approaches.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8357
How was this patch tested?
I verified that the WARN log was gone.