HDDS-10645. Support x-amz-metadata-directive in CopyObject #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kerneltime @DaveTeng0 @SaketaChalamchala @vtutrinov Could you help take a look when you have time? |
adoroszlai
reviewed
Apr 9, 2024
| } else { | ||
| OS3Exception ex = newError(INVALID_ARGUMENT, metadataCopyDirective); | ||
| ex.setErrorMessage("An error occurred (InvalidArgument) " + | ||
| "when calling the CopyObjet operation: " + |
There was a problem hiding this comment.
Suggested change
| "when calling the CopyObjet operation: " + | |
| "when calling the CopyObject operation: " + |
There was a problem hiding this comment.
Thank you for catching it. Updated.
| OS3Exception ex = newError(INVALID_ARGUMENT, metadataCopyDirective); | ||
| ex.setErrorMessage("An error occurred (InvalidArgument) " + | ||
| "when calling the CopyObjet operation: " + | ||
| "The metadata directive specified is invalid. The valid values are COPY or REPLACE."); |
There was a problem hiding this comment.
Suggested change
| "The metadata directive specified is invalid. The valid values are COPY or REPLACE."); | |
| "The metadata directive specified is invalid. Valid values are COPY or REPLACE."); |
adoroszlai
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Thanks @ivandika3 for updating the patch, LGTM. I'll wait some time for another review.
tanvipenumudy
approved these changes
Apr 10, 2024
|
Thanks @ivandika3 for the patch, @tanvipenumudy for the review. |
|
Thank you for the reviews @adoroszlai @tanvipenumudy |
Tejaskriya
pushed a commit
to Tejaskriya/ozone
that referenced
this pull request
Apr 17, 2024
ivandika3
added a commit
to ivandika3/ozone
that referenced
this pull request
May 6, 2024
(cherry picked from commit e81f5c0)
ivandika3
added a commit
to ivandika3/ozone
that referenced
this pull request
May 7, 2024
(cherry picked from commit e81f5c0)
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
(cherry picked from commit e81f5c0)
ivandika3
added a commit
to ivandika3/ozone
that referenced
this pull request
Jul 24, 2024
(cherry picked from commit e81f5c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Need to support x-amz-metadata-directive: specifies whether the metadata is copied from the source object or replaced with metadata that's provided in the request. When copying an object, you can preserve all metadata (the default) or specify new metadata. If this header isn’t specified, COPY is the default behavior.
Valid Values: COPY | REPLACE
See: https://docs.aws.amazon.com/AmazonS3/latest/API/API_CopyObject.html#API_CopyObject_RequestSyntax
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10645
How was this patch tested?
Unit test and acceptance test.
Clean CI run: https://github.com/ivandika3/ozone/actions/runs/8589734492