Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-3056. Allow users to list volumes they have access to, and optionally allow all users to list all volumes #696

Merged
merged 20 commits into from
Apr 21, 2020
Merged

HDDS-3056. Allow users to list volumes they have access to, and optionally allow all users to list all volumes #696

merged 20 commits into from
Apr 21, 2020

Commits on Apr 20, 2020

  1. Remove admin check for listVolumes so every user can list all volumes… 

    … via OM.
    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    7fb4027 View commit details
    Browse the repository at this point in the history

  2. Add new option --all for ozone sh volume list so users can list a… 

    …ll volumes via Ozone shell.
    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    00b4d86 View commit details
    Browse the repository at this point in the history

  3. Add new config key that optionally allows everyone to list all volumes.

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    693adb1 View commit details
    Browse the repository at this point in the history

  4. Allow users to list volumes they have access to. accessible = has REA… 

    …D ACL, for now.
    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    1128faf View commit details
    Browse the repository at this point in the history

  5. Simplify code; Remove filter logic in VolumeManager.

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    9c6d759 View commit details
    Browse the repository at this point in the history

  6. Rename config key ozone.om.user.volume.listall.allowed -> ozone.om.vo… 

    …lume.listall.allowed
    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    28ceabf View commit details
    Browse the repository at this point in the history

  7. Remove unused imports.

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    da9508c View commit details
    Browse the repository at this point in the history

  8. OZONE_OM_USER_VOLUME_LISTALL_ALLOWED -> OZONE_OM_VOLUME_LISTALL_ALLOWED

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    0d7b0df View commit details
    Browse the repository at this point in the history

  9. Improve doc for ozone sh volume list.

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    fba10bd View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary debug log.

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    b3dca6e View commit details
    Browse the repository at this point in the history

  11. Use checkAccess; Add new hasAcls helper function to check ACL witho… 

    …ut throwing.
    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    403ea76 View commit details
    Browse the repository at this point in the history

  12. Amend the doc.

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    2e2bc38 View commit details
    Browse the repository at this point in the history

  13. Remove unused import.

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    7bed982 View commit details
    Browse the repository at this point in the history

  14. OZONE_OM_USER_VOLUME_LISTALL_ALLOWED_DEFAULT -> OZONE_OM_VOLUME_LISTA… 

    …LL_ALLOWED_DEFAULT
    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    4d3bed8 View commit details
    Browse the repository at this point in the history

  15. Duplicate TestOzoneManagerRestart -> TestOzoneManagerListVolumes.

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    c292737 View commit details
    Browse the repository at this point in the history

  16. Add integration tests.

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    da60450 View commit details
    Browse the repository at this point in the history

  17. Clean up test.

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    7d51894 View commit details
    Browse the repository at this point in the history

  18. Enable TestOzoneManagerListVolumes (do not ignore). Expect failure fr… 

    …om timeout due to (suspected) RocksDB not being cleaned up during each mini cluster launch and setup.
    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    9445c5c View commit details
    Browse the repository at this point in the history

  19. Retest

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    1398584 View commit details
    Browse the repository at this point in the history

  20. Use read lock for listVolumes in VolumeManagerImpl.

    @smengcl
    smengcl committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    f4a8817 View commit details
    Browse the repository at this point in the history