feat: introduce data type with JSON serialization#13
Conversation
leaves12138
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I found one parser correctness issue that should be fixed before merge.
Tokenize is missing a break after handling CHAR_END_SUBTYPE (>). This makes every > token also emit a BEGIN_PARAMETER (() token at the same position. As a result, SQL-style nested type strings using subtype syntax, such as ROW<id INT> or ARRAY<INT>, cannot be parsed correctly because the token stream contains an extra ( after each >.
Please add the missing break and include a regression test for a type string containing >.
leaves12138
left a comment
There was a problem hiding this comment.
Re-reviewed the latest update. The previously reported CHAR_END_SUBTYPE fallthrough has been fixed. I did not find further blockers in this round.
Purpose
Introduce the Paimon data type system for apache-paimon-cpp, including:
DECIMAL(10,2),TIMESTAMP(9) WITH LOCAL TIME ZONE, etc.).Tests
DataTypeTestDataFieldTestDataTypeJsonParserTestRowKindTest