[PAIMON #8] fix(cmake): parse add_paimon_lib link arguments.#9
Open
slfan1989 wants to merge 1 commit into
Open
[PAIMON #8] fix(cmake): parse add_paimon_lib link arguments.#9slfan1989 wants to merge 1 commit into
slfan1989 wants to merge 1 commit into
Conversation
Author
|
@leaves12138 Could you please help review this PR when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #8.
add_paimon_lib()uses several link-relatedARG_*variables internally, but the corresponding keywords were not declared incmake_parse_arguments().This change adds the missing argument names:
STATIC_INSTALL_INTERFACE_LIBSSHARED_INSTALL_INTERFACE_LIBSSHARED_PRIVATE_LINK_LIBSso these options are parsed correctly instead of leaking into preceding link argument lists.
Tests
API and Format
No.
Documentation
No.
Generative AI tooling