[flink] Introduce drop global index procedure.#7822
Merged
Conversation
Contributor
|
Please update documentation too. |
leaves12138
approved these changes
May 12, 2026
Contributor
leaves12138
left a comment
leaves12138
left a comment
There was a problem hiding this comment.
Reviewed the Flink drop_global_index procedure against the existing Spark implementation and the global-index commit path.
The filtering by index type / global-index field id / partition predicate, grouping the delete entries by partition, and committing DataIncrement.deleteIndexIncrement(...) are consistent with the existing Spark-side procedure and other index-delete paths. The service registration and bitmap/partition/non-existent-index IT coverage also look reasonable to me.
Local checks:
git diff --cached --checkpassed after applying the PR diff locally.mvn -pl paimon-flink/paimon-flink-common ... spotless:checkpassed.- I could not complete the targeted Maven IT in this local environment because dependency resolution is currently blocked by unrelated snapshot test artifacts, but I do not see a blocker in this patch.
LGTM.
zhoulii
force-pushed
the
drop-global-index
branch
from
4036ae0 to
f43f44f
Compare
zhoulii
force-pushed
the
drop-global-index
branch
from
f43f44f to
2d071a4
Compare
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
close #7821
Tests