PARQUET-828: Do not implicitly cast ParquetVersion enum to int #216

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@@ -142,8 +145,8 @@ TEST(Metadata, TestBuildAccess) {
ASSERT_EQ(nrows / 2, rg2_column2->num_values());
ASSERT_EQ(DEFAULT_COMPRESSION_TYPE, rg2_column1->compression());
ASSERT_EQ(DEFAULT_COMPRESSION_TYPE, rg2_column2->compression());
- ASSERT_EQ(2, rg2_column1->encodings().size());
@xhochy
xhochy Jan 10, 2017 Member

Huh, how did this happen?

@xhochy
xhochy Jan 10, 2017 Member

Ah, it's because of the version switch.

@xhochy
xhochy approved these changes Jan 10, 2017 View changes
@@ -142,8 +145,8 @@ TEST(Metadata, TestBuildAccess) {
ASSERT_EQ(nrows / 2, rg2_column2->num_values());
ASSERT_EQ(DEFAULT_COMPRESSION_TYPE, rg2_column1->compression());
ASSERT_EQ(DEFAULT_COMPRESSION_TYPE, rg2_column2->compression());
- ASSERT_EQ(2, rg2_column1->encodings().size());
@xhochy
xhochy Jan 10, 2017 Member

Ah, it's because of the version switch.

@asfgit asfgit pushed a commit that closed this pull request Jan 10, 2017
@wesm @xhochy wesm + xhochy PARQUET-828: Do not implicitly cast ParquetVersion enum to int
See https://github.com/apache/parquet-mr/blob/df9d8e415436292ae33e1ca0b8da256640de9710/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java#L86, this number should be 1 for Parquet 1.0 files, I believe.

Author: Wes McKinney <wes.mckinney@twosigma.com>

Closes #216 from wesm/PARQUET-828 and squashes the following commits:

ab6773c [Wes McKinney] Do not implicitly cast ParquetVersion enum to int. Set 1.0 to 1, 2.0 to 2
585469c
@asfgit asfgit closed this in 585469c Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment