PARQUET-248: Add ParquetWriter.Builder. #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SinghAsDev, can you do a first round of review? |
|
+1, looks good to me. |
|
@isnotinvain could you take a look? I think this is a good thing to get in now so we have time to get the other object models using builders. |
|
Hi @peltekster, sorry about that. I had no idea it had been done as part of another issue. Since this is a separate issue, it should be a bit easier to merge this one and use it to simplify the other commit. Would you mind reviewing this then? |
rdblue
force-pushed
the
PARQUET-248-add-parquet-writer-builder
branch
from
a226b7b
to
63aa891
Compare
|
@isnotinvain, now that #211 is in, I've updated this and added the new options from master. I think it's about ready to go in. |
| * @return this builder for method chaining. | ||
| */ | ||
| public SELF withRowGroupSize(int rowGroupSize) { | ||
| this.blockSize = rowGroupSize; |
There was a problem hiding this comment.
should we also rename this.blockSize to be this.rowGroupSize ?
|
+1 |
This refactors the builder recently added to parquet-avro so that it can be used by all object models. The Builder class is abstract and implementations should extend it. This changes the API slightly from AvroParquetWriter, renaming withBlockSize to withRowGroupSize. The Avro builder has not been released so this isn't a breaking change.
This adds the options that have been added to master since this pull request was added.
rdblue
force-pushed
the
PARQUET-248-add-parquet-writer-builder
branch
from
63aa891
to
a1a25ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the builder recently added to parquet-avro so that it can
be used by all object models. The Builder class is abstract and
implementations should extend it.
This changes the API slightly from AvroParquetWriter, renaming
withBlockSize to withRowGroupSize. The Avro builder has not been
released so this isn't a breaking change.