/parquet-mr mirrored from git://git.apache.org/parquet-mr.git

PARQUET-665 Adds support for proto3 #407

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@markchua @lukasnalezenec @julienledem @andredasilvapinto
@markchua
Contributor

markchua commented Mar 21, 2017

This change bumps the protobuf version and adds
tests to show compatibility with proto3. It does
not actually change anything else.

Tests are mostly identical to existing tests, and tests
that tested functionality not present in proto3 are not
present (such as groups and extensions). Proto3
oneof and map are represented in the tests.

Tested by running mvn test --am --projects parquet-protobuf
@markchua
Contributor

markchua commented Mar 21, 2017

oh but of course, I need to update the .travis.yml file to install the right version
@markchua markchua PARQUET-665 Adds support for proto3 
This change bumps the protobuf version and adds
tests to show compatibility with proto3. It does
not actually change anything else.

Tested by running `mvn test --am --projects parquet-protobuf`
40ef997
@lukasnalezenec
Contributor

lukasnalezenec commented Mar 22, 2017

Hi, I will look at this ASAP
@julienledem
Member

julienledem commented Mar 24, 2017

@markchua It looks good to me. Waiting for @lukasnalezenec's feedback before merging.
@julienledem
Member

julienledem commented Apr 20, 2017

FYI: planning to merge today.

asfgit closed this in 70f2881 Apr 21, 2017

@julienledem
Member

julienledem commented Apr 21, 2017

thank you @markchua !
@andredasilvapinto

andredasilvapinto commented May 30, 2017

Do you know when this is going to be released?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment