Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2051: Pass Hadoop Configuration to AvroSchemaConverter #912

Merged
merged 1 commit into from Jun 22, 2021

Conversation

hailuand
Copy link
Contributor

@hailuand hailuand commented Jun 1, 2021

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    • TestAvroWriteSupport.java

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@hailuand
Copy link
Contributor Author

hailuand commented Jun 1, 2021

Hi @gszadovszky, can you please review this?

@gszadovszky gszadovszky changed the title PARQUET-2051 Pass Configuration to AvroSchemaConverter as to not lose… PARQUET-2051: Pass Hadoop Configuration to AvroSchemaConverter Jun 1, 2021
@gszadovszky
Copy link
Contributor

Seems that I completely forgot about this. Sorry, @hailuand. I'm merging it.

@gszadovszky gszadovszky merged commit c3009c1 into apache:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants