-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use setup-java in Github Actions #96
Conversation
0addbae
to
9d31621
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, this is great, in particular, because setup-java
knows how to use the Java instances that are already part of the base images, so the setup task does not even have to download anything.
Reverting since this broke PR validation. |
(cherry picked from commit 085e88f)
setup-scala
is deprecated so lets usesetup-java
instead