Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setup-java in Github Actions #96

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

mdedetrich
Copy link
Contributor

setup-scala is deprecated so lets use setup-java instead

Copy link

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is great, in particular, because setup-java knows how to use the Java instances that are already part of the base images, so the setup task does not even have to download anything.

@jrudolph jrudolph changed the title Use setup-java Use setup-java in Github Actions Mar 6, 2023
@jrudolph jrudolph merged commit 085e88f into apache:main Mar 6, 2023
@mdedetrich mdedetrich deleted the use-setup-java branch March 6, 2023 11:23
@jrudolph
Copy link
Contributor

jrudolph commented Mar 6, 2023

Reverting since this broke PR validation.

jrudolph added a commit that referenced this pull request Mar 6, 2023
jrudolph pushed a commit to jrudolph/incubator-pekko-http that referenced this pull request Mar 6, 2023
jrudolph added a commit that referenced this pull request Mar 6, 2023
Co-authored-by: Matthew de Detrich <matthew.dedetrich@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants