PHOENIX-5852 The zkConnectionString in LoadBalance is incorrect #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a ut for this? |
|
Hi @infraio , a ut has been added. |
stoty
reviewed
May 15, 2020
| "localhost"),configuration.get(QueryServerProperties.ZOOKEEPER_PORT_ATTRIB,"2181")); | ||
| String[] serverHosts = configuration.getStrings(QueryServerProperties.ZOOKEEPER_QUORUM_ATTRIB, "localhost"); | ||
| String clientPort = configuration.get(QueryServerProperties.ZOOKEEPER_PORT_ATTRIB, "2181"); | ||
| StringBuilder zkConnectionString = new StringBuilder(); |
There was a problem hiding this comment.
Why not just call ZKConfig.standardizeZKQuorumServerString() from HBase?
We are pulling in hbase-common anyways.
| @@ -139,6 +142,37 @@ public void testSingletonPropertyForLoadBalancer(){ | |||
| Assert.assertTrue(" the load balancer is not singleton",loadBalancer == anotherloadBalancerRef ); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testZkConnectString() { | |||
| // server port is different from the port which is set by user | |||
There was a problem hiding this comment.
Nit Technically, this is a UT, but we tend not worry about the distinction much.
(The test is fine as is, but some may argue that it should be in src/test, not src/it )
|
Fixed as you said. Please review @stoty |
|
Committed. Thanks for the fix @ZhaoBQ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHOENIX-5852