PHOENIX-5879 Fix recently introduced python 2.7 incompatibilities and…#31
Closed
stoty wants to merge 4 commits into
Closed
PHOENIX-5879 Fix recently introduced python 2.7 incompatibilities and…#31stoty wants to merge 4 commits into
stoty wants to merge 4 commits into
Conversation
… flake8 warning * downgrade dependencies to make sure setup works on 2.7 * fix python27 incompatibilities * fix flake8 warnings additional improvements: * pare down dependencies * dockerize tox tests * update docs * expose ways to start a local test PQS server from maven
Member
|
Nice, this looks good. I'll try to run through it myself. |
joshelser
approved these changes
Apr 30, 2020
Member
joshelser
left a comment
joshelser
left a comment
There was a problem hiding this comment.
Nice! everything works as advertised.
We should update setup.py to reflect ownership by the PMC and bump the version. Lukas was the original author, but he donated the code to the ASF for us to continue.
Contributor
Author
|
I've updated the author info, but I'd be happy to change it, if you can suggest a better author string. |
updated author/contact info in setup.py updated docs bumped version to 1.0.0.dev set earliest suppported 3.x version to python 3.4 in setup.py, docs, and tox setup
Add simplified date/time/timestamp fix Add unicode test
Member
Thanks! I think "Apache Software Foundation" is just fine. The other idea would be to say "Apache Phoenix", but they're more or less the same thing. This is fantastic +1 |
Contributor
Author
|
Thanks for thorough review @joshelser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… flake8 warning
additional improvements: