Use minion data directory as tmp directory for SegmentGenerationAndPushTask

[xiangfu0]

Description

Use minion data directory instead of system temp directory as SegmentGenerationAndPushTask tmp directory.
This will fix the issue that the current pinot segment generation task may fail due to any reason. The leftover segment intermediate data won't be clean up and eventually will fill up the disk.
Minion data directory is always cleaned up once the minion instance got restarted.

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

• Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

• Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

• New configuration options
• Deprecation of configurations
• Signature changes to public methods/interfaces
• New plugins added or old plugins removed

• Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.

If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text

Documentation

If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document

[codecov-io]

Codecov Report

Merging #6560 (7deceec) into master (1beaab5) will decrease coverage by 22.74%.
The diff coverage is 41.89%.

@@             Coverage Diff             @@
##           master    #6560       +/-   ##
===========================================
- Coverage   66.44%   43.70%   -22.75%     
===========================================
  Files        1075     1341      +266     
  Lines       54773    65936    +11163     
  Branches     8168     9615     +1447     
===========================================
- Hits        36396    28816     -7580     
- Misses      15700    34686    +18986     
+ Partials     2677     2434      -243     

Flag	Coverage Δ
integration	43.70% <41.89%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ot/broker/broker/AllowAllAccessControlFactory.java	100.00% <ø> (ø)
.../helix/BrokerUserDefinedMessageHandlerFactory.java	52.83% <0.00%> (-13.84%)	⬇️
...org/apache/pinot/broker/queryquota/HitCounter.java	0.00% <0.00%> (-100.00%)	⬇️
...che/pinot/broker/queryquota/MaxHitRateTracker.java	0.00% <0.00%> (ø)
...ache/pinot/broker/queryquota/QueryQuotaEntity.java	0.00% <0.00%> (-50.00%)	⬇️
...ker/routing/instanceselector/InstanceSelector.java	100.00% <ø> (ø)
...ceselector/StrictReplicaGroupInstanceSelector.java	0.00% <0.00%> (ø)
...roker/routing/segmentpruner/TimeSegmentPruner.java	0.00% <0.00%> (ø)
...roker/routing/segmentpruner/interval/Interval.java	0.00% <0.00%> (ø)
...r/routing/segmentpruner/interval/IntervalTree.java	0.00% <0.00%> (ø)
... and 1352 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e62addb...7deceec. Read the comment docs.

[Jackie-Jiang]

LGTM. Please add more context in the PR description. I think here you are trying to solve the issue of tmp directory not cleaned up properly?