New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding logger utils and allow change logger level at runtime #9180
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9180 +/- ##
=============================================
+ Coverage 28.49% 69.98% +41.48%
- Complexity 53 4756 +4703
=============================================
Files 1836 1852 +16
Lines 98103 98760 +657
Branches 14897 15021 +124
=============================================
+ Hits 27956 69113 +41157
+ Misses 67460 24773 -42687
- Partials 2687 4874 +2187
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
201b3b9
to
c6e0180
Compare
c7b817b
to
ba45cf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add some tests for the LoggerUtils
?
We want to test the following things:
- The expected return for each method
- Whether the already initialized logger can be updated
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerLogger.java
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
c3094a5
to
70dd3c6
Compare
pinot-common/src/test/java/org/apache/pinot/common/utils/LoggerUtilsTest.java
Outdated
Show resolved
Hide resolved
pinot-common/src/test/java/org/apache/pinot/common/utils/LoggerUtilsTest.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerLogger.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerLogger.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerLogger.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Show resolved
Hide resolved
b9e98fb
to
7228fa2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerLogger.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/test/java/org/apache/pinot/common/utils/LoggerUtilsTest.java
Outdated
Show resolved
Hide resolved
7228fa2
to
c5bdf14
Compare
c5bdf14
to
5395c67
Compare
Allow change logger level at runtime.
APIs:
Sample usage: