Permalink
Commits on Aug 16, 2016
  1. PIVOT-990: Fix the RepositionCallback logic in TerraMenuPopupSkin so …

    …that
    
    a menu whose width or height is greater than the display width or height
    will be positioned at 0 (X or Y as appropriate, or both), and whose
    containing Border will be sized to the limiting display dimension.  This
    allows the contained Panorama to automatically insert scroll arrows so
    the menu that has overflowed can be scrolled into view.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1756534 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Aug 16, 2016
Commits on Aug 15, 2016
  1. PIVOT-948: Add an example program that both illustrates how to use da…

    …ta binding
    
    (in this case, "selected item binding" with a ListButton), but that also serves
    as a check on the fix for this issue.  Having an unselected item used to cause
    the bind mapping not to be called during a "store" operation.  Now it is called
    always (if set), and the mapping is responsible for translating between the
    unselected state/index and the underlying stored value.
    
    Merged revision 1756437 from branches/2.0.x to trunk.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1756439 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Aug 15, 2016
  2. Add Javadoc plugin to Maven configuration.

    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1756438 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Aug 15, 2016
Commits on Jun 28, 2016
  1. PIVOT-891: Add double/triple click support in TextPane the same way i…

    …t is
    
    supported (now) in TextArea.
    
    Double click selects the word immediately under/around the mouse pointer,
    and triple click selects the line (paragraph) that is under the mouse.
    
    Essentially we just duplicated the code from TextArea into TextPane with
    appropriate (small) modifications for the difference in APIs.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1750549 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 28, 2016
Commits on Jun 21, 2016
  1. Wrong positioning of cursor in TextPane when using the END key.

    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1749542 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 21, 2016
Commits on Jun 14, 2016
  1. Code cleanup: Add Javadoc to the existing Bounds class.

    Also add null argument checks in several places that lacked it (for consistency
    with all the other checks that were there).
    
    A little reformatting of the code to make it a bit more readable.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1748459 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 14, 2016
Commits on Jun 8, 2016
  1. Code cleanup: Add an RGB display of each theme color to the ColorPale…

    …tteTest so we can
    
    visualize/inspect the current theme color values.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1747458 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 8, 2016
  2. PIVOT-989: Use the correct Charset in StringSerializer.writeObject().…

    … The "getBytes()"
    
    call was not specifying any Charset, thus getting the platform default (which on Windows
    is usually Win-1252), which is usually not the same as the UTF-8 default which is used
    in this class.  So, use the given Charset.
    
    Also, in "trunk", use the StandardCharsets.UTF_8 value, instead of searching by name.
    Note: this part of the change will not be propagated to "2.0.x" because it still needs
    to compile under Java 6.
    
    Update the StringSerializerTest with a specific test of this, and include a byte dump
    so we can actually examine the bytes to make sure (the console output, especially on
    Windows, is not helpful).
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1747445 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 8, 2016
  3. Code cleanup: Add some Javadoc to ListView.java to explain some thing…

    …s better.
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1747438 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 8, 2016
  4. PIVOT-988: Fix the inclusion check in TextPaneSkinElementView.getChar…

    …acterBounds().
    
    It was using >= offset && <= offset + length, when it should be just:
    >= offset && < offset + length
    Thus the previous element was used to get the paragraph bounds, which results in
    the position being on the previous line.
    
    This fixes a variety of problems having to do with selections in TextPane!
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1747431 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 8, 2016
  5. Add a convenience method to TextPane's Element class to get the whole…

    … text of the
    
    element, including all children, paragraph line endings, etc.
    
    Note: this parallels the more comprehensive code already in TextPane to get subsets
    of the text.  We should probably move that code into Element so there is only one
    copy of the logic.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1747386 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 8, 2016
  6. Code cleanup: Fix more comments that were wrapped in an ugly manner.

    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1747383 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 8, 2016
  7. Code cleanup: Various changes to TextPane:

    * Use the new Utils.checkNull method in a lot of places.
    * Add a "checkDocumentExists()" method and use that for a common check.
    * Add some explanatory text to several IllegalArgumentExceptions.
    * Deal with all the various types of line endings when reading text
      from a stream or file, and construct a canonical form of paragraph.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1747382 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 8, 2016
  8. Code cleanup: One more line wrapping change. Plus there is a bug (loo…

    …ks like copy/paste
    
    error) where the wrong node view is used for the character count.  I don't know what
    symptoms it would cause, but it is clearly wrong, based on all the other times similar
    logic is used.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1747379 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 8, 2016
  9. Code cleanup: some time ago, the whole source in "trunk" was reformatted

    automatically to wrap at a certain width.  Unfortunately this made some
    code pretty ugly by making a bunch of short comment lines with the leftover
    stuff.  So, correct some of that.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1747378 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 8, 2016
  10. Enhancement: Add a "userData" property to the TextPane "Node" class

    so that applications building a document can attach their own data
    structures to the various nodes of the document for cross-referencing
    or other uses (such as syntax coloring).
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1747377 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 8, 2016
  11. Code cleanup: Add some explanatory Javadoc to some of the TextPane code

    because it is not clear sometimes what offsets mean and what methods do
    to the novice user.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1747376 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 8, 2016
  12. Code cleanup: some time ago, the whole source in "trunk" was reformatted

    automatically to wrap at a certain width.  Unfortunately this made some
    code pretty ugly by making a bunch of short comment lines with the leftover
    stuff.  So, correct some of that.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1747375 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Jun 8, 2016
Commits on May 24, 2016
  1. PIVOT-984: Add the list of CSS3/X11 color names/values into GraphicsU…

    …tilities
    
    and add lookup of them to the "decodeColor" method.
    
    Next step is a demo/text program.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1745408 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed May 24, 2016
  2. PIVOT-976: More Javadoc fixes for the warnings from Java 8.

    This is the LAST!  All the remaining warnings have been removed.
    
    NOTE: this does NOT mean that all the Javadoc is correct, complete, informative,
    helpful, or otherwise as good as it could be.  All this means is that the
    Javadoc processor no longer complains about it when you run "ant doc".
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1745405 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed May 24, 2016
  3. PIVOT-976: More Javadoc fixes for the warnings from Java 8.

    Continuing on down the list, to finish off the WTK skin classes.
    
    Most of the changes were missing @return or @param values.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1745388 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed May 24, 2016
Commits on May 10, 2016
  1. Two small fixes in the Query class:

    * Use the "getContentLengthLong()" method to get the complete content length
      (instead of the possibly truncated 32-bit length).
    * Call the "QueryListener.failed()" method before we throw the QueryException
      if the server itself returned a "not OK" status.  This seemed to be an
      oversight in the original code since every other place we throw we also
      call this listener method.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1743220 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed May 10, 2016
Commits on May 2, 2016
  1. PIVOT-976: More Javadoc fixes for the warnings from Java 8.

    Continuing on down the list, now the last (except for DropTarget.java) of
    the "wtk" files.  Almost all of the changes were missing descriptions for
    @param tags.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1742040 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed May 2, 2016
  2. PIVOT-976: More Javadoc fixes for the warnings from Java 8.

    Continuing on down the list, now into the directories past "wtk", namely
    "content", "effects", and "media".  All these were @param tags that had
    no description, although I did reformat one Enum list for clarity also.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1742028 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed May 2, 2016
  3. PIVOT-976: More Javadoc fixes for the warnings from Java 8.

    Continuing on down the list, basically, to finish off the "Listener"
    classes, and a few others along the way.  Almost all are descriptions
    for @param elements that were listed but had no descriptions.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1742009 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed May 2, 2016
Commits on Apr 22, 2016
  1. PIVOT-987: Address the different handling of script return values

    from attributes versus elements.
    
    The script return value was being ignored in AttributeInvocationHandler
    and the default values were always being used.  But in the similar
    code in ElementInvocationHandler the script result was being used
    and the defaults only used if the script method returns nothing.
    
    Bring the code for attributes in line with that for elements.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1740570 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Apr 22, 2016
Commits on Mar 16, 2016
  1. PIVOT-986: One more minor correction (that probably doesn't even make

    a difference), but for consistency's sake:  use the "isFileHidden"
    method in the other place that was just calling "isHidden" in the VFS
    Browser code.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1735288 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Mar 16, 2016
  2. PIVOT-986: When viewing hidden files in one of the browsers, dim

    the icon and the file name so it is clear that the file/directory
    is hidden.
    
    Put a "Show hidden files" checkbox into the FileBrowserWithCharsetTest
    program so we can test this functionality in the regular file
    browser as well as the VFS Browser tested earlier.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1735282 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Mar 16, 2016
  3. PIVOT-986: Provide a property for the FileBrowser and VFSBrowser classes

    to allow viewing of hidden files.
    
    There is already a STYLE in the skins of these classes that is nicely
    analogous, so make a new style in the skins called "showHiddenFiles",
    provide getter and setter methods and then "do the math" inside the
    skins to take out the HIDDEN_FILE_FILTER if this flag is set, while
    still using it when the flag is false.
    
    Provide a sort-of pass-through style in the SheetSkins to set the
    style in the component skin (for convenience).  Again this is based
    on the way the "hideDisabledFiles" style works (exactly).
    
    That's it, really.  Except add a simple test program in VFSBrowserTest
    (for the VFSBrowser, obviously) to prove that the code works.  I need
    to find a similar suitable place to test the regular FileBrowser case,
    though, which will be a separate submission.
    
    The FileBrowser parts of this change will be crossed to the 2.0.x
    branch in due course.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1735181 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Mar 16, 2016
Commits on Mar 15, 2016
  1. Misc. TextPane changes (more):

    * Add the supporting methods in ComponentNode, Node, and TextNode
      to support the "getText(start, end)" method just added to TextPane.
    * Add some Javadoc (mostly about offsets being document-relative or
      node-relative).
    * Correct some weird Javadoc line breaks.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1735008 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Mar 15, 2016
  2. Misc. TextPane improvements:

    * Add some Javadoc, mostly pertaining to the offsets and whether they
      are document-relative or block-relative.
    * Notably add the "getText(start, end)" method so TextPane can (almost
      completely) be used as a drop-in replacement with added functionality
      for a TextArea control.
    * Add some error messages to the IllegalStateExceptions that are thrown
      everywhere.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1735007 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Mar 15, 2016
Commits on Mar 14, 2016
  1. PIVOT-976: More Javadoc fixes for the warnings from Java 8.

    Continuing on down the list, basically.  Almost all of these are
    @param descriptions, although some are @return and some are @throws.
    
    Also continued a little bit using the Utils.checkNull method in some
    places in the components that were updated.  This is a bit off-track
    for Javadoc, but there is no separate JIRA for these changes, so ....
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1734997 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Mar 14, 2016
  2. Code cleanup: Add Javadoc to the "Span" class. Retrofit all the null

    parameter checks to use the new Utils.checkNull() method for consistency.
    Note: there is NO change in functionality with this, except that all
    the IllegalArgumentExceptions will now have a message instead of none.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1734988 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Mar 14, 2016
  3. Code cleanup: Make an enhancment to Utils.checkNull() to allow an

    empty descriptiont string to also count for throwing a "plain"
    IllegalArgumentDescription (i.e., without a message).  This will
    eliminate weird messages in this case.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1734986 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Mar 14, 2016
Commits on Feb 12, 2016
  1. PIVOT-985 (again): Since we supported the British spelling variation …

    …of these
    
    two colors, it seems only right to support this variation for the "gray" value
    as well (meaning "grey").  So, add that in the same way as the other two.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/pivot/trunk@1730108 13f79535-47bb-0310-9956-ffa450edef68
    Roger Lee Whitcomb committed Feb 12, 2016