Permalink
Browse files

FindBugs fix

- fixed "Should be a static inner class"
- see http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568178 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information...
kiwiwings committed Feb 14, 2014
1 parent 3ceb93b commit 92a488a28b1f6761dfac19e7b2fe8a76f776d425
@@ -294,7 +294,7 @@ public Section(final byte[] src, final int offset)
* <p>Represents an entry in the property list and holds a property's ID and
* its offset from the section's beginning.</p>
*/
- class PropertyListEntry implements Comparable<PropertyListEntry>
+ static class PropertyListEntry implements Comparable<PropertyListEntry>
{
int id;
int offset;
@@ -108,7 +108,7 @@ private boolean isEmpty(Cell cell) {
*
* @author Roman Kashitsyn
*/
- private class SimpleCellWalkContext implements CellWalkContext {
+ private static class SimpleCellWalkContext implements CellWalkContext {
public long ordinalNumber = 0;
public int rowNumber = 0;
public int colNumber = 0;
@@ -167,7 +167,7 @@ public void commit() throws IOException{
/**
* The core document properties
*/
- public class CoreProperties {
+ public static class CoreProperties {
private PackagePropertiesPart part;
private CoreProperties(PackagePropertiesPart part) {
this.part = part;
@@ -273,7 +273,7 @@ public PackagePropertiesPart getUnderlyingProperties() {
/**
* Extended document properties
*/
- public class ExtendedProperties {
+ public static class ExtendedProperties {
private org.openxmlformats.schemas.officeDocument.x2006.extendedProperties.PropertiesDocument props;
private ExtendedProperties(org.openxmlformats.schemas.officeDocument.x2006.extendedProperties.PropertiesDocument props) {
this.props = props;
@@ -287,7 +287,7 @@ private ExtendedProperties(org.openxmlformats.schemas.officeDocument.x2006.exten
/**
* Custom document properties
*/
- public class CustomProperties {
+ public static class CustomProperties {
/**
* Each custom property element contains an fmtid attribute
* with the same GUID value ({D5CDD505-2E9C-101B-9397-08002B2CF9AE}).
@@ -66,6 +66,7 @@ public ZipInputStreamZipEntrySource(ZipInputStream inp) throws IOException {
}
public InputStream getInputStream(ZipEntry zipEntry) {
+ assert (zipEntry instanceof FakeZipEntry);
FakeZipEntry entry = (FakeZipEntry)zipEntry;
return entry.getInputStream();
}
@@ -187,7 +187,7 @@ public Chunk createChunk(byte[] data, int offset) {
* The definition of a Command, which a chunk may hold.
* The Command holds the value, this describes it.
*/
- public class CommandDefinition {
+ public static class CommandDefinition {
private int type;
private int offset;
private String name;
@@ -17,10 +17,11 @@ Licensed to the Apache Software Foundation (ASF) under one or more
package org.apache.poi.hslf.record;
-import org.apache.poi.util.LittleEndian;
import java.io.IOException;
import java.io.OutputStream;
+import org.apache.poi.util.LittleEndian;
+
/**
* A Slide Atom (type 1007). Holds information on the parent Slide, what
* Master Slide it uses, what Notes is attached to it, that sort of thing.
@@ -173,7 +174,7 @@ public void writeOut(OutputStream out) throws IOException {
* usual record header. Since it's a fixed size and tied to
* the SlideAtom, we'll hold it here.)
*/
- public class SSlideLayoutAtom {
+ public static class SSlideLayoutAtom {
// The different kinds of geometry
public static final int TITLE_SLIDE = 0;
public static final int TITLE_BODY_SLIDE = 1;
@@ -17,12 +17,12 @@ Licensed to the Apache Software Foundation (ASF) under one or more
package org.apache.poi.hslf.record;
-import org.apache.poi.util.LittleEndian;
-
import java.io.IOException;
import java.io.OutputStream;
import java.util.Vector;
+import org.apache.poi.util.LittleEndian;
+
/**
* These are tricky beasts. They contain the text of potentially
* many (normal) slides. They are made up of several sets of
@@ -181,7 +181,7 @@ public void writeOut(OutputStream out) throws IOException {
* includes sets of TextHeaderAtom and TextBytesAtom/TextCharsAtom,
* along with some others.
*/
- public class SlideAtomsSet {
+ public static class SlideAtomsSet {
private SlidePersistAtom slidePersistAtom;
private Record[] slideRecords;

0 comments on commit 92a488a

Please sign in to comment.