Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename text segment class #110

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@pjfanning
Copy link
Contributor

pjfanning commented May 27, 2018

With 4.0.0 release, it would be nice to fix the class name.
There aren't too many nice approaches to retaining compatibility for the old name of the class TextSegement.

@asfgit

This comment has been minimized.

Copy link

asfgit commented May 27, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/POI-Github-PullRequests/46/

@centic9

This comment has been minimized.

Copy link
Member

centic9 commented May 27, 2018

+1 from me, XWPF is officially still in "scratchpad", please add an entry in status.xml which flags this as import change to have it properly documented in the changelog.

@asfgit asfgit closed this in 917dace May 27, 2018

asfgit pushed a commit that referenced this pull request May 27, 2018

@pjfanning pjfanning deleted the pjfanning:rename-text-segment branch May 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.