Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAPIType.isFixedLength: not true in case of length > 8 #143

Closed
wants to merge 1 commit into from

Conversation

@dhoelzl
Copy link

commented Apr 5, 2019

MAPIType.isFixedLength: not true in case of length > 8 as fixed length properties are always stored as 8 bytes (zero-padded if length < 8) and cannot exceed 8 bytes.

Writing e.g. MAPIType CLS_ID which has length 16 would fail otherwise.
(Defined here:

public static final MAPIType CLS_ID = new MAPIType(0x0048, "CLS ID GUID", 16);
)

Dominik Hölzl
MAPIType.isFixedLength: not true in case of length > 8 as fixed lengt…
…h properties are always stored as 8 bytes (zero-padded if length < 8)
@asfgit

This comment has been minimized.

Copy link

commented Apr 5, 2019

Can one of the admins verify this patch?

@kiwiwings

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Patch applied via r1857708, thank you for bringing this up.
First I thought about having an additional attribute or specific handling of CLS_ID, but for custom types your solution seems to be straight forward.

@dhoelzl dhoelzl closed this May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.