Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertiesChunk.writeProperties: no need to write ASCII_STRING properties as UNICODE_STRING #146

Closed
wants to merge 9,840 commits into from
Closed

PropertiesChunk.writeProperties: no need to write ASCII_STRING properties as UNICODE_STRING #146

wants to merge 9,840 commits into from

Conversation

dhoelzl
Copy link

@dhoelzl dhoelzl commented May 10, 2019

PropertiesChunk.writeProperties: no need to write ASCII_STRING properties as UNICODE_STRING as written raw value (PropertyValue.getRawValue) is formatted as ASCII_STRING

pjfanning and others added 30 commits December 17, 2018 19:06
@pjfanning
[bug-63005] disable the reading of DTDs altogether
9953339 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849123 13f79535-47bb-0310-9956-ffa450edef68
@pjfanning
lgtm issues: potential index out of bounds exceptions
cec45d6 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849127 13f79535-47bb-0310-9956-ffa450edef68
@pjfanning
[bug-63005] ignore openxml4j/ContentTypeHasEntities.ooxml
7c26c97 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849128 13f79535-47bb-0310-9956-ffa450edef68
@kiwiwings
only refactorings to break up the long method
00a7b49 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849130 13f79535-47bb-0310-9956-ffa450edef68
@pjfanning
[bug-63013] add XWPFRun setLang method
04d1627 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849152 13f79535-47bb-0310-9956-ffa450edef68
@pjfanning
[github-137] solves/unifies blank/missing value colection for PRODUCT…
fa0066d 
…/MDETERM/GEOMEAN. Thanks to gallonfizik. This closes #137

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849237 13f79535-47bb-0310-9956-ffa450edef68
@kiwiwings
#63017 - Remove rows from a XSLFTable
337bc9e 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849244 13f79535-47bb-0310-9956-ffa450edef68
@kiwiwings
#63017 - Remove rows from a XSLFTable
5de5b8c 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849248 13f79535-47bb-0310-9956-ffa450edef68
@pjfanning
fix index check in HemfDraw
c5ca61e 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849250 13f79535-47bb-0310-9956-ffa450edef68
@kiwiwings
#62886 - Regression extracting text from corrupted docx files
bd951d2 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849252 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Add missing jacoco-lib to test-scratchpad
9211380 
Remove some xmlns that are not needed any more now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849280 13f79535-47bb-0310-9956-ffa450edef68
@centic9
One more file-leak-detector exclude
c95b62e 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849286 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Rework test somewhat and enable logger to better indicate if the test is
d5e2aca 
failing because JDK options are missing with JDK >= 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849287 13f79535-47bb-0310-9956-ffa450edef68
@kiwiwings
fix old xerces errors because of not available disallow-doctype parse…
deef652 
…r feature

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849336 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Add more file-leak exlcudes for the mass regression testing
719b102 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849715 13f79535-47bb-0310-9956-ffa450edef68
Code-style: Unify how arrays are specified from C-style to normal Jav…
2bd8838 
…a-style

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849716 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Bug 62884: sheetnum is not checked in InternalWorkbook.setSheetHidden()
bf5fad6 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849717 13f79535-47bb-0310-9956-ffa450edef68
@centic9
JavaDoc fixes/additions and some IDE warnings removed
8e0501a 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849718 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Simplify some string operations
e827a69 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849760 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Remove unnecesssary semicolons
ee0dc99 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849761 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Fix incorrect constant for pict-files
3219b3a 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849762 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Fix various IDE warnings and some JavaDoc adjustments
8011fdc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849763 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Bug 62839: Adjust MathX.floor() to handle negative values the same
0089868 
way as Excel/LibreOffice

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849764 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Add some simple coverage of HSLF-Dev-Tools
312baae 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849765 13f79535-47bb-0310-9956-ffa450edef68
@centic9
IDE and JavaDoc fixes, close() in tests
480c081 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849812 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Re-instate two dev-tools that we lost in some refactoring,
6aafdf2 
at least OOXMLPrettyPrint is still very useful for comparing ooxml-files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849813 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Bug 62629: Allow to handle files with invalid content types for pictures
e0484ac 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849814 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Adjust/enhance tests for bug 62275 some more
9501862 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849836 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Adjust test to not require src/documentation to be available
c554aea 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849837 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Add XMLBeans jobs for JDK 8 and 11.
30835c9 
Add initial version of Jenkins DSL for the Github-PullRequest build-job

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849838 13f79535-47bb-0310-9956-ffa450edef68
@pjfanning
Copy link
Contributor

@dhoelzl could you open a discussion on the POI dev list? https://poi.apache.org/help/index.html - or raise a bugzilla issue

kiwiwings and others added 21 commits May 12, 2019 23:22
@kiwiwings
exclude H27
3f78c04 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859162 13f79535-47bb-0310-9956-ffa450edef68
@kiwiwings
revert exclude H27 / don't complain on mkdir
0d045c5 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859163 13f79535-47bb-0310-9956-ffa450edef68
@pjfanning
[github-148] update license text in pom file. Thanks to Vincent Priva…
c27fa22 
…t. This close #148

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859202 13f79535-47bb-0310-9956-ffa450edef68
@tballison
Bug 63431 -- unbug ChunkedCipherInputStream's read()
0c7afff 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859251 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Refine JavaDoc of WorkbookFactory slightly
c233158 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859368 13f79535-47bb-0310-9956-ffa450edef68
@centic9
FileMagic now has patterns with up to 12 bytes (JPG)
52be9c9 
Avoid exception if a very short file is encountered
Add more tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859564 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Include actual found type in exception when encountering unexpected t…
3dbf8df 
…ype of file in ExtractorFactory

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859565 13f79535-47bb-0310-9956-ffa450edef68
@centic9
Use TempFile to avoid problems with temporary directories in Maven bu…
a25bff9 
…ilds

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859575 13f79535-47bb-0310-9956-ffa450edef68
@Alain-Bearez
Added more chart supports.
27c37d6 
fixed bug while creating chart with bar and line series.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859589 13f79535-47bb-0310-9956-ffa450edef68
@Alain-Bearez
code cleanup plus fix for bug 63153
ee81606 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859590 13f79535-47bb-0310-9956-ffa450edef68
@Alain-Bearez
fix potential input resource leaks (LGTM)
0e541eb 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859591 13f79535-47bb-0310-9956-ffa450edef68
@Alain-Bearez
fix potential output resource leaks (LGTM)
3f49c45 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859592 13f79535-47bb-0310-9956-ffa450edef68
@Alain-Bearez
fix boxed variable is never null
8ccac98 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859593 13f79535-47bb-0310-9956-ffa450edef68
@Alain-Bearez
fix whitespace contradicts operator precedence
bc66e7a 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859594 13f79535-47bb-0310-9956-ffa450edef68
@Alain-Bearez
fix result of multiplication cast to wider type
2922ea2 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859595 13f79535-47bb-0310-9956-ffa450edef68
@Alain-Bearez
fix missing space in string literal (LGTM)
c3e549c 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859596 13f79535-47bb-0310-9956-ffa450edef68
@pjfanning
switch svn jars to https site
06b8886 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859625 13f79535-47bb-0310-9956-ffa450edef68
@pjfanning
try to remove http refs from some pom files
7604076 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859663 13f79535-47bb-0310-9956-ffa450edef68
@Alain-Bearez
code inspired from Axel Richter on StackOverflow
5e070fd 
closes #139
closes #144

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859676 13f79535-47bb-0310-9956-ffa450edef68
@pjfanning
try to use more https urls in pom.xml
897f4a1 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859701 13f79535-47bb-0310-9956-ffa450edef68
@pjfanning
remove some tab indents
2e01bb3 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859758 13f79535-47bb-0310-9956-ffa450edef68
@pjfanning
Copy link
Contributor

https://bz.apache.org/bugzilla/show_bug.cgi?id=63447

pjfanning
pjfanning reviewed May 23, 2019
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a sample file to test this code on? If so, could you use it in a unit test?

pjfanning and others added 2 commits May 26, 2019 09:43
@pjfanning
[github-149] improve MAPIMessage.guess7BitEncoding, improve MAPIMessa…
721180d 
…ge.getHtmlBody. Thanks to Dominik Hölzl. This closes #149

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860043 13f79535-47bb-0310-9956-ffa450edef68
PropertiesChunk.writeProperties: no need to write ASCII_STRING proper…
9a1bd08 
…ties as UNICODE_STRING as written raw value (PropertyValue.getRawValue) is formatted as ASCII_STRING
@dhoelzl
Copy link
Author

dhoelzl commented May 27, 2019

I have created a unit test to verify this.

@asfgit asfgit closed this Oct 6, 2019
@centic9
Copy link
Member

centic9 commented Oct 9, 2019

Unfortunately this was closed by some automated job, but we cannot reopen it ourselves, please reopen if this is still an active PR so it does not get lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjfanning pjfanning pjfanning left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
8 participants
@dhoelzl @asfgit @pjfanning @centic9 @iannoche @kiwiwings @tballison @Alain-Bearez