Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWPFPicture: easy access to width and depth #150

Closed
wants to merge 4 commits into from
Closed

XWPFPicture: easy access to width and depth #150

wants to merge 4 commits into from

Conversation

@dourouc05
Copy link

@dourouc05 dourouc05 commented May 26, 2019

I suppose adding a test case wouldn't hurt (something like calling XWPFRun.addPicture then calling these two new methods).

(BTW, would a pull request to add an overload to XWPFRun.addPicture be accepted? It would be to compute the width and depth from the input file, using javax.ImageIO -- an acceptable dependency or not?)

@asfgit
Copy link

@asfgit asfgit commented May 26, 2019

Can one of the admins verify this patch?

Loading

}

/**
* Returns the width of the picture (in EMU).
Copy link
Contributor

@Alain-Bearez Alain-Bearez May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

width was copied from above.

Most of the other API use Units.toPoints() to convert out of EMU to more human understandable points.

Loading

@dourouc05
Copy link
Author

@dourouc05 dourouc05 commented Jun 24, 2019

I've just added a test for the new methods. Is this enough for merging?

Loading

@dourouc05
Copy link
Author

@dourouc05 dourouc05 commented Jul 19, 2019

@pjfanning @Alain-Bearez is this OK to merge?

Loading

@asfgit asfgit closed this in 6672611 Jul 19, 2019
@pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Jul 19, 2019

Loading

asfgit pushed a commit that referenced this issue Oct 6, 2019
Alain-Bearez pushed a commit to cuali/poi that referenced this issue Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants