Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWPFPicture: easy access to width and depth #150

Closed
wants to merge 4 commits into from

Conversation

@dourouc05
Copy link

commented May 26, 2019

I suppose adding a test case wouldn't hurt (something like calling XWPFRun.addPicture then calling these two new methods).

(BTW, would a pull request to add an overload to XWPFRun.addPicture be accepted? It would be to compute the width and depth from the input file, using javax.ImageIO -- an acceptable dependency or not?)

@asfgit

This comment has been minimized.

Copy link

commented May 26, 2019

Can one of the admins verify this patch?

}

/**
* Returns the width of the picture (in EMU).

This comment has been minimized.

Copy link
@Alain-Bearez

Alain-Bearez May 28, 2019

Contributor

width was copied from above.

Most of the other API use Units.toPoints() to convert out of EMU to more human understandable points.

dourouc05 added 2 commits May 28, 2019
@dourouc05

This comment has been minimized.

Copy link
Author

commented Jun 24, 2019

I've just added a test for the new methods. Is this enough for merging?

@dourouc05

This comment has been minimized.

Copy link
Author

commented Jul 19, 2019

@pjfanning @Alain-Bearez is this OK to merge?

@asfgit asfgit closed this in 6672611 Jul 19, 2019

@pjfanning

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.