Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWPFParagraph: direct control over keepNext. #152

Closed
wants to merge 2 commits into from
Closed

XWPFParagraph: direct control over keepNext. #152

wants to merge 2 commits into from

Conversation

@dourouc05
Copy link

@dourouc05 dourouc05 commented Jun 1, 2019

No description provided.

@asfgit
Copy link

@asfgit asfgit commented Jun 1, 2019

Can one of the admins verify this patch?

Loading

* Indicates whether this paragraph should be kept on the same page as the next one.
*/
public boolean isKeepNext() {
if (getCTP() != null && getCTP().getPPr() != null) {
Copy link
Contributor

@pjfanning pjfanning Jun 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this compile? seems to me, this has no return if the if-condition fails

Loading

Copy link
Author

@dourouc05 dourouc05 Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've corrected this and added a test. Better?

Loading

@pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Jul 16, 2019

this is merged - #156 had the same code and I merged it there

Loading

@dourouc05 dourouc05 closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants