Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POIXMLProperties: add setters for ExtendedProperties, like other classes #157

Closed

Conversation

@dourouc05
Copy link

commented Jun 25, 2019

…ses.

@asfgit

This comment has been minimized.

Copy link

commented Jun 25, 2019

Can one of the admins verify this patch?

@dourouc05

This comment has been minimized.

Copy link
Author

commented Jul 19, 2019

@pjfanning better this way?

@pjfanning

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

The new test fails:

        FAILED
expected null, but was:<Apache POI>
junit.framework.AssertionFailedError: expected null, but was:<Apache POI>
        at org.apache.poi.ooxml.TestPOIXMLProperties.testWorkbookExtendedPropertiesGettersSetters(TestPOIXMLProperties.java:131)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

@asfgit asfgit closed this in ec60bea Jul 19, 2019

@pjfanning

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

I fixed the test and merged with https://svn.apache.org/repos/asf/poi/trunk@1863432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.