/ poi Public
XWPFNumbering.addAbstractNum will definitely throw an exception #171
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
XWPFNumbering.addAbstractNum code is an if branch. There are two points to note:
abstractNum.getAbstractNum ()is not null, you must ensure that AbstractNumId has a value, so in order for users to find the correct AbstractNumId value, two getter methods are exposed, of course, the list cannot be modified.
abstractNum.getAbstractNum ()is null, an exception will be thrown when cascading the method of
abstractNum.getAbstractNum (), so you need to set the attribute CtAbstractNum of the abstractNum.
PS: For the first point, we can also assert in the
XWPFNumbering.addAbstractNumthat AbstractNumId is not null, fail fast.