Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add null checker to sourceRow so it can be skipped if it's null #177

wants to merge 3 commits into from


Copy link

@xjlin0 xjlin0 commented Apr 23, 2020

When copying the sheet in the memory, if the row is null, currently it will cause NPE. So just a null checker to protect it, similar to how it skips null columns as of now. @zmau

2020-04-23 09:49:07.390 [,myservice,,] ERROR https-jsse-nio-9420-exec-2 [dispatcherServlet] - Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is java.lang.NullPointerException] with root cause
java.lang.NullPointerException: null

Copy link

Would you be able to provide a test xlsx file and a test case that reproduces the issue? We like to have regression tests.

@asfgit asfgit closed this in 979d1b4 Apr 26, 2020
Copy link

centic9 commented Apr 26, 2020

Sorry, I was too fast, I could quickly reproduce it and fix it as part of some other improvement to the tests.

Copy link

xjlin0 commented Apr 27, 2020

it's ok, as long as the null row can now be skipped and will be release in the next version, I will be happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
3 participants