-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Super sxssf #184
Super sxssf #184
Conversation
@pjfanning This is to resume discussions and figure out if this code is still useful since it's a year since the previous MR. |
This code does not compile |
The workbook constructor does not compile but this does
|
- SXSSF and SuperSXSSF use different approaches - Reduces code duplication in SuperSXSSFWorkbook - Added unit tests
Thanks. Merged with f06c454 We can treat this as beta for now, as I expect that we might need to add some checks to handle edge cases. |
I'll check our existing code that uses this extension. What's the URL of the maven SNAPSHOTS repository? |
Thanks, will have a look. I was expecting it at https://repository.apache.org/content/groups/snapshots. |
mobreza#1 (comment) provides an example of how to use code (except the |
@mobreza I'm struggling to think of a good name for these classes. SuperSXSSF was too vague but EmittingSXSSF is not right either. How about DeferredSXSSF or LazySXSSF because of the fact that the actual generation of the rows is delayed until you start writing to the output stream? |
Migration from 3.17 (!) to 5.0.0-SNAPSHOT required renaming the I didn't experience any problems with generating Excel files. Downloads start immediately and canceling the download request results in ending the database scan:
Our code uses templates and blank workbooks. |
Renamed the classes in 9f8b864 |
Rebased MR #141 on master.