Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Adding utility method to check any protection is enforced #27
Conversation
prasad-babu
added some commits
Jan 25, 2016
|
Any chance of a small unit-test together with a sample document (or using one of the available sample-documents) which covers the new function? |
prasad-babu
commented
Feb 15, 2016
|
Added test case with sample document |
prasad-babu
closed this
Feb 15, 2016
prasad-babu
reopened this
Feb 15, 2016
prasad-babu
commented
Feb 15, 2016
|
sorry, i accidentally closed the request. |
centic9
commented on the diff
Feb 15, 2016
...java/org/apache/poi/xwpf/usermodel/XWPFTableCell.java
| @@ -233,8 +233,9 @@ public XWPFVertAlign getVerticalAlignment() { | ||
| XWPFVertAlign vAlign = null; | ||
| CTTcPr tcpr = ctTc.getTcPr(); | ||
| if (tcpr != null) { | ||
| - CTVerticalJc va = tcpr.getVAlign(); | ||
| - vAlign = stVertAlignTypeMap.get(va.getVal().intValue()); | ||
| + CTVerticalJc va = tcpr.getVAlign(); | ||
| + if(va != null) |
|
|
asfgit
closed this
in 677b19a
Feb 15, 2016
|
FYI, I left out the seemingly unrelated change to XWPFTableCell.java, please create a separate PR with a short description and unit-test which reproduces the problem that you try to fix with it if you think this should be applied as well. |
prasad-babu
commented
Feb 16, 2016
|
Sorry that was different bug fix. Unfortunately it was added to this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
prasad-babu commentedJan 25, 2016
This utility method is useful if it is to check only whether document is
enforced (any type) or not