Adding utility method to check any protection is enforced #27

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@prasad-babu

This utility method is useful if it is to check only whether document is
enforced (any type) or not

prasad-babu added some commits Jan 25, 2016

Adding utility method to check any protection is enforced
This utility method is useful if it is to check only whether document is
enforced (any type) or not
Fixed nullpointer exception
By default table cell doesnt have any vertical alignment details
@centic9

This comment has been minimized.

Show comment
Hide comment
@centic9

centic9 Feb 14, 2016

Member

Any chance of a small unit-test together with a sample document (or using one of the available sample-documents) which covers the new function?

Member

centic9 commented Feb 14, 2016

Any chance of a small unit-test together with a sample document (or using one of the available sample-documents) which covers the new function?

Adding unit test for enforced with util method
Adding unit test for enforced with util method
@prasad-babu

This comment has been minimized.

Show comment
Hide comment
@prasad-babu

prasad-babu Feb 15, 2016

Added test case with sample document

Added test case with sample document

@prasad-babu prasad-babu reopened this Feb 15, 2016

@prasad-babu

This comment has been minimized.

Show comment
Hide comment
@prasad-babu

prasad-babu Feb 15, 2016

sorry, i accidentally closed the request.

sorry, i accidentally closed the request.

- CTVerticalJc va = tcpr.getVAlign();
- vAlign = stVertAlignTypeMap.get(va.getVal().intValue());
+ CTVerticalJc va = tcpr.getVAlign();
+ if(va != null)

This comment has been minimized.

@centic9

centic9 Feb 15, 2016

Member

Is this change related? Looks like a different change/fix

@centic9

centic9 Feb 15, 2016

Member

Is this change related? Looks like a different change/fix

@asfgit asfgit closed this in 677b19a Feb 15, 2016

@centic9

This comment has been minimized.

Show comment
Hide comment
@centic9

centic9 Feb 15, 2016

Member

FYI, I left out the seemingly unrelated change to XWPFTableCell.java, please create a separate PR with a short description and unit-test which reproduces the problem that you try to fix with it if you think this should be applied as well.

Member

centic9 commented Feb 15, 2016

FYI, I left out the seemingly unrelated change to XWPFTableCell.java, please create a separate PR with a short description and unit-test which reproduces the problem that you try to fix with it if you think this should be applied as well.

@prasad-babu

This comment has been minimized.

Show comment
Hide comment
@prasad-babu

prasad-babu Feb 16, 2016

Sorry that was different bug fix. Unfortunately it was added to this pull request.

Sorry that was different bug fix. Unfortunately it was added to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment