/poi mirrored from git://git.apache.org/poi.git

Adding a new method to the XSSFConditionalFormatting class #42

Closed
wants to merge 3 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lucailmartini @centic9
@lucailmartini

lucailmartini commented Oct 28, 2016

This pull request addresses Bug #60314.
The new method can be used to change the formatting range of an existing XSSFConditionalFormatting without the need of removing and then re-adding the rule.

If someone is able to provide an implementation for the HSSF format, the method could be added to the interface ConditionalFormatting.

lucailmartini added some commits Oct 28, 2016

@lucailmartini lucailmartini added idea .gitignore cb432e9
@lucailmartini lucailmartini added public void setFormattingRanges(CellRangeAddress[] ranges) meth… 
…od to the XSSFConditionalFormatting class

Resolve Bug 60314 https://bz.apache.org/bugzilla/show_bug.cgi?id=60314
 d96581a
@lucailmartini lucailmartini Implemented setFormattingRanges for HSSF. 
Pulled up the setFormattingRanges to the ConditionalFormatting interfaces.
Pulled up the unit test to the BaseTestConditionalFormatting class.
Added some other unit tests to address corner cases.
 8b7b64b
@lucailmartini

lucailmartini commented Nov 7, 2016

I implemented setFormattingRanges also for HSSF.

Pulled up the setFormattingRanges to the ConditionalFormatting interface.
Pulled up the unit test to the BaseTestConditionalFormatting class.
Added some other unit tests to address corner cases.
New code is fully covered by unit tests.

asfgit closed this in 76a0c63 Nov 7, 2016

@centic9
Member

centic9 commented Nov 7, 2016

Thanks a lot for the nice patch, this is applied in trunk now, this should be included starting with 3.16-beta1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment