New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new method to the XSSFConditionalFormatting class #42

Closed
wants to merge 3 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@lucailmartini

lucailmartini commented Oct 28, 2016

This pull request addresses Bug #60314.
The new method can be used to change the formatting range of an existing XSSFConditionalFormatting without the need of removing and then re-adding the rule.

If someone is able to provide an implementation for the HSSF format, the method could be added to the interface ConditionalFormatting.

lucailmartini added some commits Oct 28, 2016

Implemented setFormattingRanges for HSSF.
Pulled up the setFormattingRanges to the ConditionalFormatting interfaces.
Pulled up the unit test to the BaseTestConditionalFormatting class.
Added some other unit tests to address corner cases.
@lucailmartini

This comment has been minimized.

Show comment
Hide comment
@lucailmartini

lucailmartini Nov 7, 2016

I implemented setFormattingRanges also for HSSF.

Pulled up the setFormattingRanges to the ConditionalFormatting interface.
Pulled up the unit test to the BaseTestConditionalFormatting class.
Added some other unit tests to address corner cases.
New code is fully covered by unit tests.

lucailmartini commented Nov 7, 2016

I implemented setFormattingRanges also for HSSF.

Pulled up the setFormattingRanges to the ConditionalFormatting interface.
Pulled up the unit test to the BaseTestConditionalFormatting class.
Added some other unit tests to address corner cases.
New code is fully covered by unit tests.

@asfgit asfgit closed this in 76a0c63 Nov 7, 2016

@centic9

This comment has been minimized.

Show comment
Hide comment
@centic9

centic9 Nov 7, 2016

Member

Thanks a lot for the nice patch, this is applied in trunk now, this should be included starting with 3.16-beta1

Member

centic9 commented Nov 7, 2016

Thanks a lot for the nice patch, this is applied in trunk now, this should be included starting with 3.16-beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment