Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Image Optimisations #54
I need to be able to generate spreadsheets with 2000 images fast enough for a synchronous HTTP request.
The slowdown was caused by the cost of creating and sorting
First commit adds a benchmark using http://openjdk.java.net/projects/code-tools/jmh/
Prior to my changes
Afterwards we get 10x improvement in execution time, and 100x in memory:
Happy to back out the benchmark inclusion if you don't want to include another test dependency.
I like that benchmarking library. I have no reservations about making it a test dependency. There are plenty of other places we could use a benchmarking library. We have a few places of roll-your-own timed unit tests which will inevitably break on a sluggish build slave.
Aside from our unit tests, integration tests, api checks, we could also trend execution memory and speed. This will be especially helpful as we look for an xmlbeans replacement.
I've committed your changes, essentially unmodified, with a couple whitespace changes in SVN r1795252 https://svn.apache.org/viewvc?view=revision&revision=1795252
This is really good stuff. Be careful, though. We might just ask you to be a committer with this quality of pull requests.