Fixing a search error #655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the suggestion, applied the actual fix now. Note: I did not change to getRList() as this can have negative impact on performance, we saw that calling getRList() may introduce additional overhead. Also did not add the appendText() method, please add a separate PR with accompanying tests if you would like to add such a method. |
alexjansons
pushed a commit
to alexjansons/poi
that referenced
this pull request
Nov 23, 2024
The result was wrong for certain combinations of runs and found positions. The adjusted implementation fixes this. Also add a number of additional tests to verify results are correct. Closes apache#655 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1918986 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
searchText retruns wrong index.