-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share chart data implementation between XSSFChart and XSLFChart through XDDF #68
Conversation
A shame I decided to go with docx4j to implement a higher level charting library for pptx... We would have had a lot of common code to share. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimming through the changes, looks good to me. I think this is a good idea!
This PR looks good and ready to merge. We should probably have you sign a contributor license agreement before merging. I sent an email to your cua.li address with details. |
CI also is green on commit de37f95, see https://builds.apache.org/view/P/view/POI/job/POI-Github-PullRequests/7/ |
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816383 13f79535-47bb-0310-9956-ffa450edef68
The main goal of this work is to be able to:
What is left to be done: