Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share chart data implementation between XSSFChart and XSLFChart through XDDF #68

Closed
wants to merge 28 commits into from

Conversation

@Alain-Bearez
Copy link
Contributor

@Alain-Bearez Alain-Bearez commented Aug 10, 2017

The main goal of this work is to be able to:

  • duplicate a slide that has a chart on it (https://bz.apache.org/bugzilla/show_bug.cgi?id=57835);
  • more easily access definitions for axes;
  • more easily set data series for axes;
  • share code between XSLF and XSSF: XSSFChart and XSLFChart are using XDDFChartData.

What is left to be done:

  • complete implementation of first five chart types;
  • implement other chart types.
@aperrot42
Copy link

@aperrot42 aperrot42 commented Sep 13, 2017

A shame I decided to go with docx4j to implement a higher level charting library for pptx... We would have had a lot of common code to share.

@asfgit
Copy link

@asfgit asfgit commented Sep 28, 2017

Can one of the admins verify this patch?

@onealj
onealj approved these changes Oct 31, 2017
Copy link
Contributor

@onealj onealj left a comment

Skimming through the changes, looks good to me. I think this is a good idea!

@Alain-Bearez
Copy link
Contributor Author

@Alain-Bearez Alain-Bearez commented Nov 1, 2017

@onealj After this pull request will have been merged, I suggest you continue your review on the next PR related to XDDF: #72

The third PR about XDDF is not ready yet.

@onealj
Copy link
Contributor

@onealj onealj commented Nov 3, 2017

This PR looks good and ready to merge. We should probably have you sign a contributor license agreement before merging. I sent an email to your cua.li address with details.

@asfgit asfgit closed this in c795f2e Nov 26, 2017
@Alain-Bearez Alain-Bearez deleted the cuali:xddf-usermodel branch Nov 26, 2017
Alain-Bearez pushed a commit to cuali/poi that referenced this pull request Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.