I apologize for the late response and thank you for those corrections. Should I supply a new patch including these changes to bugzilla or is the pull request sufficient? Is another pull request to Apache/POI needed?
We can use this Pull Request and your existing github branch while we review this change.
We are in the middle of releasing 3.17 and we need to decide whether to include this.
Would you be able to fix the broken tests?
junit.framework.AssertionFailedError: wrong # of valid values expected:<32> but was:<0>
Im working on the TestXSSFDataValidation and will make an xls file test suite. I have noticed that test suites between xls and xlsx are sometimes duplicated. Is it sufficient to keep the test cases within the workbook the same?