Define XDDF user model for shape properties to be shared between XSLF, XSSF and XWPF #72
Conversation
Testing Github->Jenkins integration: run tests |
Can one of the admins verify this patch? |
FYI, CI on this branch failed with
See https://builds.apache.org/job/POI-Github-PullRequests/3/console |
@Alain-Bearez the changes generally look good but would it be possible to add more unit tests? |
It would be a bunch of tests for getters and setters... I will try to find some time before the end of the year to copy and adapt the tests from |
@Alain-Bearez If this is ready to merge, I can go ahead and do that. |
@pjfanning I was only waiting for Dominik to confirm that the integration tests are passing for that branch. |
Alain-Bearez
pushed a commit
to cuali/poi
that referenced
this pull request
Dec 12, 2019
…m GitHub) git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1820369 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The main goal of this work is to provide a user model API in order to handle the shape properties without using underlying XmlBeans objects and interfaces. Among others, handling properties related to colors is made simpler by returning and accepting an abstract XDDFColor, which has six distinct implementations, where the developers were required to check whether or not one of the six properties was set.
What is left to be done: