Add the "final" modifier to public static fields. #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability. http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL
This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability. http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL
|
Can one of the admins verify this patch? |
Alain-Bearez
pushed a commit
to cuali/poi
that referenced
this pull request
Dec 12, 2019
…he#78. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812234 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability.
http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL